Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

Improve structure of dev env #20

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ pragma solidity 0.8.16;

import '@openzeppelin/contracts/access/AccessControl.sol';
import '@openzeppelin/contracts/utils/cryptography/ECDSA.sol';
import './IVault.sol';

/**
* @notice Base contract for Yellow Clearing. Responsible for all operations regarding Yellow Network.
Expand Down Expand Up @@ -187,7 +186,7 @@ abstract contract YellowClearingBase is AccessControl {

// REVIEW: change docs comment after checks are added
/**
* @notice Suspend participantand set their status to Suspended. Emit `ParticipantStatusChanged` event.
* @notice Suspend participant and set their status to Suspended. Emit `ParticipantStatusChanged` event.
* @dev Require AUDITOR_ROLE to invoke. Participant must be present and not migrated
* @param participant Address of participant to suspend.
*/
Expand Down Expand Up @@ -225,7 +224,7 @@ abstract contract YellowClearingBase is AccessControl {
}

/**
* @notice Set participiant data to data supplied. Emit `ParticipantDataChanged` event.
* @notice Set participant data to data supplied. Emit `ParticipantDataChanged` event.
* @dev Require REGISTRY_MAINTAINER_ROLE to invoke. Participant must not have been migrated.
* @param participant Address of participant to set data of.
* @param data Data to set.
Expand Down Expand Up @@ -320,8 +319,8 @@ abstract contract YellowClearingBase is AccessControl {
}

/**
* @notice Internal logic of migrating participant data. Can be overriden to change.
* @dev Internal logic of migrating participant data. Can be overriden to change.
* @notice Internal logic of migrating participant data. Can be overridden to change.
* @dev Internal logic of migrating participant data. Can be overridden to change.
* @param participant Address of participant to migrate data of.
* @param data Participant data to migrate.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import '../YellowClearingBase.sol';
*/
contract TESTYellowClearingV1 is YellowClearingBase {
// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
// SECUTIRY VULNERABILITY HERE \/ \/ \/
// SECURITY VULNERABILITY HERE \/ \/ \/
constructor(YellowClearingBase previousImplementation)
YellowClearingBase(previousImplementation)
{}
Expand Down
39 changes: 0 additions & 39 deletions contracts/custody-factory/ISimpleVaultFactory.sol

This file was deleted.

62 changes: 0 additions & 62 deletions contracts/custody-factory/SimpleERC20.sol

This file was deleted.

Loading