This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
Improve development environment structure #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plsthink
added a commit
that referenced
this pull request
Oct 21, 2022
* Improve development environment structure (#21) * remove custody, custody-factory and nitro-protocol * move vault * remove unused vault import, fix some comments * fix comments * structurize tests and src * clearing extracted * move and rename accounts * fix constructor argument type * fix tests imports * apply comment suggestions Co-authored-by: nksazonov <nsazonov@openware.com> * Improve dev env plugins usage (#22) * remove .vscode from gitignore * add vscode workspace settings * add recommended extensions * fix indentation * chore eslintrc * update eslintignore * remove prettier from eslint settings * remove npmignore * update prettier settings * remove solhint, change hardhat extension settings * update hardhat config * update tsconfig rules * fix ts errors * fix spell errors in files * rename vault upgradability to upgradeability * change module in tsconfig to commonjs * remove unused scripts * linter fixes almost done * ref vault upgradability to comply with eslint rules * remove unnecessary Contract type * ref vesting tests to comply with updated elint * ref implement all eslint rules * remove unnecessary Contract type * tsconfig inherit from base config * add eslint plugins & rules * remove `bracketSpacing` rule from prettier * add / to gitignore and prettierignore * remove user-dependent rules * ref ts files to comply to new eslint rules * run lint:fix * tweak some eslint rules Co-authored-by: nksazonov <nsazonov@openware.com> * fix: vault impl setup deployer roles (#25) * remove public grant deployer roles function * add upgrade call test * apply code style changes Co-authored-by: nksazonov <nsazonov@openware.com> Co-authored-by: Sazonov Nikita <35502225+nksazonov@users.noreply.github.com> Co-authored-by: nksazonov <nsazonov@openware.com>
plsthink
added a commit
that referenced
this pull request
Oct 21, 2022
* Improve development environment structure (#21) * remove custody, custody-factory and nitro-protocol * move vault * remove unused vault import, fix some comments * fix comments * structurize tests and src * clearing extracted * move and rename accounts * fix constructor argument type * fix tests imports * apply comment suggestions Co-authored-by: nksazonov <nsazonov@openware.com> * Improve dev env plugins usage (#22) * remove .vscode from gitignore * add vscode workspace settings * add recommended extensions * fix indentation * chore eslintrc * update eslintignore * remove prettier from eslint settings * remove npmignore * update prettier settings * remove solhint, change hardhat extension settings * update hardhat config * update tsconfig rules * fix ts errors * fix spell errors in files * rename vault upgradability to upgradeability * change module in tsconfig to commonjs * remove unused scripts * linter fixes almost done * ref vault upgradability to comply with eslint rules * remove unnecessary Contract type * ref vesting tests to comply with updated elint * ref implement all eslint rules * remove unnecessary Contract type * tsconfig inherit from base config * add eslint plugins & rules * remove `bracketSpacing` rule from prettier * add / to gitignore and prettierignore * remove user-dependent rules * ref ts files to comply to new eslint rules * run lint:fix * tweak some eslint rules Co-authored-by: nksazonov <nsazonov@openware.com> * fix: vault impl setup deployer roles (#25) * remove public grant deployer roles function * add upgrade call test * apply code style changes Co-authored-by: nksazonov <nsazonov@openware.com> Co-authored-by: Sazonov Nikita <35502225+nksazonov@users.noreply.github.com> Co-authored-by: nksazonov <nsazonov@openware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13. Part of #11.