Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Fix #483: Unbind hangs in node v10 #485

Closed
wants to merge 5 commits into from
Closed

Fix #483: Unbind hangs in node v10 #485

wants to merge 5 commits into from

Commits on Jul 9, 2018

  1. Call unbind callback when socket is connected

    @jgeurts
    jgeurts committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    ff9d0b9 View commit details
    Browse the repository at this point in the history

  2. Prevent .end() from being called twice

    @jgeurts
    jgeurts committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    592ca0d View commit details
    Browse the repository at this point in the history

  3. End the test after all assertions

    @jgeurts
    jgeurts committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    3704040 View commit details
    Browse the repository at this point in the history

  4. Remove extra t.end()

    @jgeurts
    jgeurts committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    927483a View commit details
    Browse the repository at this point in the history

  5. Use a new client to test unbind when not connected

    @jgeurts
    jgeurts committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    bb2529a View commit details
    Browse the repository at this point in the history