Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display errors above docstrings in tooltip popups? #152

Open
kim-em opened this issue Mar 27, 2020 · 2 comments
Open

Display errors above docstrings in tooltip popups? #152

kim-em opened this issue Mar 27, 2020 · 2 comments

Comments

@kim-em
Copy link
Contributor

kim-em commented Mar 27, 2020

I often investigate tactic errors by using the tooltip.

Unfortunately in VSCode the tooltip will display both the docstring for the tactic, and then below that the error message. Especially as the docstrings become better and better (and longer and longer!) this makes the tooltip less useful (it's hard to scroll inside them without losing them).

Could we switch the order, and put the error first?

@bryangingechen
Copy link
Contributor

So this is trickier than I thought it would be. The error messages are provided by "Diagnostics" in diagnostics.ts and the docstrings / types, etc. are provided by the "HoverProvider" in hover.ts. I could well be missing something, but I couldn't find any way to switch the ordering of these two sources in the hover popup.

@alexpeattie
Copy link
Contributor

Looks like this behaviour is coming from VSCode 🤔 :

microsoft/vscode#73120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants