Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ObjectPool performance #674

Closed
codemercenary opened this issue Jul 27, 2015 · 1 comment
Closed

Fix ObjectPool performance #674

codemercenary opened this issue Jul 27, 2015 · 1 comment
Assignees
@codemercenary
Milestone
v0.7.2

Comments

@codemercenary
Copy link
Contributor

ObjectPool has terrible performance because we used std::shared_ptr to track objects that are in the cache, when really we should be using std::unique_ptr. This design choice was made in order to support libstdc, but because we no longer support it, we should probably fix ObjectPool's current performance issue, especially if we are recommending that people use it in preference of operator new.
@codemercenary codemercenary added this to the v0.7.2 milestone Jul 27, 2015
@codemercenary codemercenary mentioned this issue Jul 28, 2015
Merged
@codemercenary codemercenary self-assigned this Jul 28, 2015
@codemercenary codemercenary mentioned this issue Jul 28, 2015
Merged
@codemercenary
Copy link
Contributor Author

Addressed by #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codemercenary codemercenary

Labels
None yet
Projects
None yet
Milestone
v0.7.2
Development

No branches or pull requests
1 participant
@codemercenary