Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Visual Studio 2017 32 bit builds #1019

Merged
merged 2 commits into from
Jun 9, 2017
Merged

Fix Visual Studio 2017 32 bit builds #1019

merged 2 commits into from
Jun 9, 2017

Conversation

yeswalrus
Copy link
Contributor

workaround alignment issues with gtest

@yeswalrus yeswalrus requested a review from jdonald June 9, 2017 20:30
@jdonald
Copy link
Contributor

jdonald commented Jun 9, 2017

Does this have to be a C-style cast? static_cast<> doesn't work?

@jdonald
Copy link
Contributor

jdonald commented Jun 9, 2017 •
edited
Loading

Would atomicobj.load() work?

@jdonald jdonald merged commit b6eaa59 into master Jun 9, 2017
@jdonald jdonald deleted the fix-vs2017-32 branch June 9, 2017 23:27
@jdonald jdonald removed their request for review October 31, 2017 20:10
@jdonald jdonald modified the milestone: v1.0.5 Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeswalrus @jdonald