Fix leak in DispatchQueue::Abort #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a true leak, but rather technical leak that exists because things are not destroyed at the expected time. Delayed dispatchers attached to a `DispatchQueue` are not deleted when the `Abort` call completes. They are eventually destroyed in `~DispatchQueue`, but they should be instead destroyed as soon as it is possible to know that's needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a true leak, but rather technical leak that exists because things are not destroyed at the expected time. Delayed dispatchers attached to a
DispatchQueueare not deleted when theAbortcall completes. They are eventually destroyed in~DispatchQueue, but they should be instead destroyed as soon as it is possible to know that's needed.