number of resources updates on selection

[AllanOXDi]

Summary

• Ensures the proper count and ancestor counts are dynamically populated based on the selected topic.
• Select all Checkbox counts the total number of resources in the working resources pool in the topic tree.
• updates the count of individual resources selected within the pool.
  closes Quiz Creation Select Resources - Display proper count & ancestor counts on the card. #11784

References

#11784

Reviewer guidance

• Verify that the ancestor counts are correctly updated within the selected topic.
• Confirm that the "Select All" Checkbox counts the total number of resources within the topic tree.

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b13.dev0_git.525.gf6ca9d9b.pex
Windows Installer (EXE)	kolibri-0.16.0b13.dev0+git.525.gf6ca9d9b-unsigned.exe
Debian Package	kolibri_0.16.0b13.dev0+git.525.gf6ca9d9b-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b13.dev0+git.525.gf6ca9d9b-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b13.dev0+git.525.gf6ca9d9b-0.1.0-debug.apk
TAR file	kolibri-0.16.0b13.dev0+git.525.gf6ca9d9b.tar.gz
WHL file	kolibri-0.16.0b13.dev0+git.525.gf6ca9d9b-py2.py3-none-any.whl

[nucleogenesis]

Key changes that are needed for merge:

• The first number of the "x of y resources selected" string needs to be updated per my comments
• Clean up unused commented code
• Remove side-effects code from the isSelectAllChecked computed property

One thing that is not asked for in the original issue but that I've noted below which would be helpful here is:

• Update the behavior when the user is unselecting-all so that instead of wiping the user's changes, we just remove the selectable items in the content list from the working resource pool

[nucleogenesis]

This is making it so that every card shows the same # of resources selected out of however many children there are. For example, the QA Channel's QTI folder has 3 resources in it, but when I select 4 resources from the CK12 folder the QTI card says "4 of 3 resources selected"

This should instead be using the ancestor(s) property on the items in the workingResourcePool where basically count should be "the number of items in the working resource pool who has this topic as an ancestor".

[nucleogenesis]

All of this commented out stuff can be removed

[nucleogenesis]

Lines 278-282 here seem out of place. Since isSelectAllChecked is supposed to just be a Boolean computed property, it can get really hairy if we introduce a side effect here like adding items to the resource pool.

This logic probably belongs below in the method we're passing as the handler function for the @changeselectall event on the ContentCardList. I'll add some more thoughts there.

[nucleogenesis]

I think that maybe this logic is altogether not necessary here. It seems like you're aiming to handle the user's "select all" click while also including all of the folders' children in that "Select all".

The logic for "selecting folders" can be handled in a separate issue, so this should be reverted to the return this.contentList.every(...).

One thing to bear in mind is that even when we do allow users to select folders, the only time we'll place all of the topic's children into the working resource list is if that folder meets the criteria for having a checkbox in the first place as defined in #11790

[nucleogenesis]

Removing the setting of isSelectAllChecked here is good as it's a computed property.

In my note on that isSelectAllChecked property I mentioned that the side-effects of manipulating the working resource pool should probably be moved here.

In the else block here, however, rather than resetWorkingResourcePool this should instead remove all items in the content list from the working resource pool. resetWorkingResourcePool just undoes all changes the user has made since opening the panel, which is not desired here.

In this case, you'd need to do a this.contentList.forEach(content => this.removeFromWorkingResourcePool(content)) (or something along those lines -- you'll probably also want to be sure to filter out Topics as we aren't permitting full topic selection until #11790 is implemented)

[nucleogenesis]

Changes here look good thanks @AllanOXDi - let's find a time to jump on a call to clean up the conflicts so we can get it merged!