Unnecessary kolibri store in tests #11852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use responsive composable instead of mixin to fix errors from the mixin.
Release v0.16.x
github-actions
bot
added
APP: Learn
Build Artifacts
|
|
Excellent - this definitely removes some unnecessary references! The main question now is just confirming there are no other places that we could do this cleanup. I will take a quick glance through your PR code checked out locally to double check! |
|
From a quick grep, I suspect there may be more instances we could tidy up here. I searched for |
github-actions
bot
added
DEV: renderers
|
@rtibbles i have made some changes |
rtibbles
approved these changes
Feb 21, 2024
|
Excellent, this seems to have much wider coverage! |
poju3185
pushed a commit
to poju3185/kolibri
that referenced
this pull request
Mar 15, 2024
* Use responsive composable instead of mixin to fix errors from the mixin. * fix:unnecessary-Kolibri-store-in-tests * Update CardGrid.vue * Update CardGrid.vue * fix:unnecessary-Kolibri-store-in-tests * Update utils.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #11725 by removing unnecessary uses of the core Kolibri store in JavaScript test files. With the introduction of custom theming, the theming state was initially added to the core Vuex state. However, the reactive theming state has been extracted from Vuex and now lives independently. Consequently, injecting the store into component tests is no longer needed.
References
fixes #11725