Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: GitHub Actions Workflow for Scheduled Morango Integration Tests #11931

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

GarvitSinghal47
Copy link
Contributor

Fixes #11903

Summary

Integration tests for Kolibri's morango implementation are crucial for testing syncing features across multiple instances. These tests are disabled by default and require specific conditions to run. To ensure regular testing, a new GitHub Actions workflow is proposed to run these tests on a weekly schedule.

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment SIZE: small labels Mar 1, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postgres configuration is absolutely required here, would be good to separate postgres and sqlite into separate jobs rather than sequential steps so we get a fuller report.

With thats done, doing a matrix of Python versions for Sqlite would add additional confidence.

.github/workflows/morongo_integration.yml Show resolved Hide resolved
.github/workflows/morongo_integration.yml Outdated Show resolved Hide resolved
.github/workflows/morongo_integration.yml Show resolved Hide resolved
…oduce Python version matrix for SQLite testing
@GarvitSinghal47 GarvitSinghal47 requested a review from rtibbles March 2, 2024 05:41
@GarvitSinghal47 GarvitSinghal47 requested a review from rtibbles March 6, 2024 04:22
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! I can't spot any more issues with my eyes, so we'll let this run and see if it works!

@rtibbles rtibbles merged commit 91ef72f into learningequality:develop Mar 6, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: dev-ops Continuous integration & deployment SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run morango integration tests on a schedule in GH actions
2 participants