Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content_id access from wrong object #11993

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

himanshuc3
Copy link

@himanshuc3 himanshuc3 commented Mar 15, 2024

Summary

Remove wrongful access of property resulting in silent console error.
Root issue being content_id being accessed from content rather than contentNode. It would be better to have consistent prop naming and replacing content with contentNode or visa versa so as to avoid such errors in future.

References

References #9074

Before:
151972657-a545f8f1-2d1e-4a12-80df-b48e60dbb370

After:
Screenshot from 2024-03-15 22-29-45

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: very small labels Mar 15, 2024
@himanshuc3
Copy link
Author

@bjester I assume I don't need to do anything further wrt CI builds.

@rtibbles
Copy link
Member

Excellent work, thank you!

@rtibbles rtibbles merged commit 85303c7 into learningequality:develop Mar 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught errors in the content modal in a channel with custom navigation
2 participants