Introduce flake8-print as pre-commit hook with migration of print to logger #11994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: backend
Build Artifacts
|
rtibbles
requested changes
Mar 16, 2024
There was a problem hiding this comment.
We also specify the flake8 version in our dev requirements, so would be good to add the flake8-print plugin there too: https://github.com/learningequality/kolibri/blob/develop/requirements/dev.txt#L3
| @@ -6,6 +6,7 @@ | |||
| import tempfile | |||
| import time | |||
| import zipfile | |||
| from builtins import FileNotFoundError | |||
There was a problem hiding this comment.
I have good news - we no longer support Python 2.7 on develop, so we don't need to do this.
There was a problem hiding this comment.
Got it! I was wondering why its giving me error. Turns out i was in py2.7 venv 😆
.pre-commit-config.yaml
Outdated
| @@ -5,6 +5,9 @@ repos: | |||
| hooks: | |||
| - id: trailing-whitespace | |||
| - id: flake8 | |||
| additional_dependencies: [ | |||
| 'flake8-print==3.1.4' | |||
There was a problem hiding this comment.
We should be able to use flake8-print==5.0.0, as we are no longer supporting Python 2.7 on develop!
Note that with version 5, they changed the codes to T2* not T0*.
rtibbles
approved these changes
Mar 17, 2024
|
Thank you, this all looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
flake8-print:3.1.4which is back-compatible with py2.7printwithloggerReferences
Fixes #11990
Reviewer guidance
I was getting
packages/kolibri-tools/lib/i18n/crowdin.py:158:12: F821 undefined name 'FileNotFoundError', so i imported it from builtinsWasn't sure about https://github.com/learningequality/kolibri/blob/develop/kolibri/core/logger/utils/user_data.py#L50 so used noqa. I know logger can be used here, but was not sure to remove print or not
Testing checklist
PR process
Reviewer checklist
yarnandpip)