Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write to disk options for build command #12006

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

thesujai
Copy link
Contributor

Summary

This exposes --write-to-disk flag in build that writes file to disk instead of webpack

References

Fixes #4826

Reviewer guidance

In https://github.com/learningequality/kolibri/blob/develop/package.json#L15 Should there be a prod argument?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: tools Internal tooling for development SIZE: small labels Mar 20, 2024
@MisRob MisRob requested a review from rtibbles March 21, 2024 07:27
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the diff can be a bit smaller, and no need to disable the cache in this case that I can see.

);
runWebpackBuild(mode, bundleData, false, {
...options,
cache: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to utilize the webpack cache here? It should help with build performance either way.

Also, the use of hot is limited to the devserver being active, which we are passing false for, so I think this if could do the warn, then we could update the runWebpackBuild to simply be:

runWebpackBuild(mode, bundleData, !options.writeToDisk && mode === modes.DEV, options);

and not have to invoke it separately in the if statement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I thought cache will fill the dev's system

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So yes, if hot and cache are not being modified then i will run the webpack build with your suggestions. Thank You

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache is better managed than the writing built files to disk, so I wouldn't worry too much!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!! Thank You

@rtibbles rtibbles self-assigned this Mar 21, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@rtibbles rtibbles merged commit 8c75103 into learningequality:develop Mar 21, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: tools Internal tooling for development SIZE: small SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add write-to-disk watch mode for kolibri tools to allow single origin dev testing.
2 participants