EQM: Side panel back / close icon UX improvements #12311
Conversation
github-actions
bot
added
APP: Coach
| <KIconButton | ||
| v-if="closeButtonIconType" | ||
| :icon="closeButtonIconType" | ||
| class="close-button" | ||
| :style="closeButtonStyle" | ||
| :ariaLabel="closeButtonMessage" | ||
| :tooltip="closeButtonMessage" | ||
| @click="closePanel" | ||
| /> |
There was a problem hiding this comment.
Moved this into here so that the rest of the stuff in .header-content is in the same container for spacing for the icon buttons.
| @@ -20,27 +20,25 @@ | |||
|
|
|||
| <!-- Fixed header --> | |||
| <div | |||
| v-show="$slots.header" | |||
There was a problem hiding this comment.
Not needed now since the icon button always lives here
| @@ -5,10 +5,18 @@ | |||
| ref="resourcePanel" | |||
| alignment="right" | |||
| sidePanelWidth="700px" | |||
| :closeButtonIconType="closeBackIcon" | |||
| closeButtonIconType="close" | |||
There was a problem hiding this comment.
We're injecting the "back" icon where/when we want it now into the #header slot, so we hard-code "close" here so that the X is always there.
Build Artifacts
|
| } | ||
| router.push({ | ||
| name: PageNames.EXAM_CREATION_ROOT, | ||
| params: { ...route.value.params }, |
There was a problem hiding this comment.
Should be specific here, see e.g.
(although I noticed in searching for this, there are still lots of places just doing a general spread).
Because of the way Vue router works, items that are not in the URL still end up in the params state, which can cause unexpected bugs down the line.
rtibbles
dismissed
their stale review
Issue addressed, waiting for manual QA for approval.
|
Hi @nucleogenesis - could you please have a look why some checks haven't completed yet here so that I can test the latest build? |
nucleogenesis
force-pushed
the
fix--sidepanel-routing-icon
branch
from
e66ebac to
b68a309
Compare
|
@pcenov I fixed the merge conflict and seems to have gotten things flowing again on the checks |
Summary
onClickOutside, reworks logic around "canGoBack"References
Closes #12308
Reviewer guidance
Please check for regressions wherever else the side panel is used in the Learn library area.
Also, see that the UX changes defined in the linked issue are applied and that the UX is improved overall while using the side panel throughout quiz creation.