Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap section deletion modal in focus trap #12373

Merged

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Jun 27, 2024

Summary

This pull request includes the addition of FocusTrap to CreateQuizSection in order to maintain focus within the section deletion confirmation modal. Additionally, it addresses the bug where selecting the cancel button failed to exit the modal.

deleteSection.mp4

References

Fixes #12303

Reviewer guidance

  1. Create a new quiz.
  2. Select options within a section and press delete section.
  3. Use the tab key to navigate between CANCEL to DELETE.
  4. Confirm that selecting CANCEL closes the modal.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jun 27, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not manually tested, but this does seem like the right fix.

Meta-comment, has integrating the FocusTrap component into KModal been mooted previously? If not, should it be?

@radinamatic radinamatic self-requested a review June 27, 2024 21:24
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing of the fix also checks out.

@rtibbles rtibbles merged commit d966f48 into learningequality:develop Jun 28, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EQM: Delete section bugs
2 participants