Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use useNow composable in ElapsedTime component #12377

Merged

Conversation

AlexVelezLl
Copy link
Member

Summary

This PR introduces the useNow composable in ElapsedTime component

References

Closes #12114

Reviewer guidance

Check that everything continues working ok in the places where ElapsedTime component is used.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@AlexVelezLl AlexVelezLl force-pushed the usenow-in-elapsedtime branch from a019cd8 to ed3d1a6 Compare June 28, 2024 14:50
@AlexVelezLl AlexVelezLl requested a review from rtibbles June 28, 2024 14:58
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look right to me. A quick manual check of a place where the elapsed time component is used should be enough here.

Suggest looking at any of the coach tools report pages which list "Last activity" or somesuch.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the manual test checks out also.

@rtibbles rtibbles merged commit 1554295 into learningequality:develop Jun 28, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use useNow composable in ElapsedTime component
2 participants