Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count descendants not ancestors #12394

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jul 2, 2024

Summary

  • Updates lesson resource page to fetch number of descendants for the currently displayed topic (a value we precompute during annotation)
  • Use this to display selection metadata
  • Adds selection metadata to channels as well
  • Ensures that the resource cache is properly populated even on page refresh
  • Does flyby fix of Lesson Creation back button behaviour, which on multi-class setups resulted in not going back to the intended page

References

Fixes #12387

Reviewer guidance

Manage the resources in a lesson, ensure that when resources are selected "X of Y resources selected" is always properly displayed


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from marcellamaki July 2, 2024 14:50
@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 2, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jul 2, 2024
rtibbles added 2 commits July 2, 2024 12:11
Return descendant count for current topics, not ancestor counts for current lesson resources.
@rtibbles rtibbles force-pushed the exponential_descendants branch from 2c77ebe to 31d82aa Compare July 2, 2024 19:11
@pcenov
Copy link
Member

pcenov commented Jul 3, 2024

LGTM no issues observed while manually testing.

@marcellamaki marcellamaki merged commit 37cfb63 into learningequality:develop Jul 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: backend Python, databases, networking, filesystem... DEV: frontend TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kolibri stalls during lesson resource management
3 participants