Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static paths for hashi and h5p static file upload #12538

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 6, 2024

Summary

  • Fixes issue where paths were discarded (because of the -j flag) during unzipping of static file assets
  • Removes use of -j flag and instead uses an appropriately deeply targeted mv to put files in the correct place
  • Fixes minor issue where the final release block step was not waiting on the APK and Raspberry Pi image jobs

References

Fixes #12515

Reviewer guidance

I tested this by doing this with the actual 0.17.0 whl file asset downloaded into my dist folder and then doing the steps in the actions job. This is what allowed me to have the properly formatted files in the correct folders for manual upload to GCS.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the Kolibri 0.17: Planned Patch 1 milestone Aug 6, 2024
@github-actions github-actions bot added the DEV: dev-ops Continuous integration & deployment label Aug 6, 2024
Copy link
Member

@DXCanas DXCanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just hope I didn't influence the initial addition of the -j flag 🙃

@rtibbles rtibbles merged commit 0f5561a into learningequality:release-v0.17.x Aug 6, 2024
34 checks passed
@rtibbles rtibbles deleted the auto_upload branch August 6, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: dev-ops Continuous integration & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants