Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text unreadable in dark mode when Netflix item is not found on TMDB #286

Closed
JVT038 opened this issue Feb 18, 2023 · 3 comments · Fixed by #288 or #290
Closed

Text unreadable in dark mode when Netflix item is not found on TMDB #286

JVT038 opened this issue Feb 18, 2023 · 3 comments · Fixed by #288 or #290

Comments

@JVT038
Copy link
Collaborator

JVT038 commented Feb 18, 2023

image

The text in this screenshot is difficult to read when it is in dark mode.
Preferably, change the color to a darker color, like black.
@leepeuker
Copy link
Owner

leepeuker commented Feb 19, 2023 •
edited
Loading

Yes, and the rating edit icon on movie detail pages is barley visible in dark.

edit: fixed

@JVT038
Copy link
Collaborator Author

JVT038 commented Feb 20, 2023

image

The login page does not have dark mode.
I think it should have dark mode if the theme cookie is set to dark.

@leepeuker
Copy link
Owner

Rating icon and netflix import issues are fixed (thanks for the help @JVT038 )

The last release enabled the dark mode on the login page accidentally. The login page was not prepared for this and looks shitty in dark mode, I am working on improving this.

This was linked to pull requests Mar 2, 2023
Fix color issue with edit rating button on movie detail pages in dark mode #288
Merged
Improve login page UI elements in dark mode #290
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@leepeuker @JVT038