From 56323e6a84d8048e2dec8f41f6addbba2e6c5e5f Mon Sep 17 00:00:00 2001 From: Andreas Henriksson Date: Sun, 18 Aug 2024 01:39:13 +0200 Subject: [PATCH] contrib/splitfont: Fix build with gcc 14 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add includes as suggested to fix missing implicit declarations and a bunch of build failures that appeared with gcc 14: ``` cc -O2 -g -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro splitfont.c -o splitfont splitfont.c: In function ‘dosplit’: splitfont.c:19:17: error: implicit declaration of function ‘exit’ [-Wimplicit-function-declaration] 19 | exit(1); | ^~~~ splitfont.c:8:1: note: include ‘’ or provide a declaration of ‘exit’ 7 | #include +++ |+#include 8 | splitfont.c:19:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] 19 | exit(1); | ^~~~ splitfont.c:19:17: note: include ‘’ or provide a declaration of ‘exit’ splitfont.c:21:13: error: implicit declaration of function ‘strlen’ [-Wimplicit-function-declaration] 21 | if (strlen(fontfile) >= sizeof(filename) - 4) { | ^~~~~~ splitfont.c:8:1: note: include ‘’ or provide a declaration of ‘strlen’ 7 | #include +++ |+#include 8 | splitfont.c:21:13: warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch] 21 | if (strlen(fontfile) >= sizeof(filename) - 4) { | ^~~~~~ splitfont.c:21:13: note: include ‘’ or provide a declaration of ‘strlen’ splitfont.c:23:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] 23 | exit(1); | ^~~~ splitfont.c:23:17: note: include ‘’ or provide a declaration of ‘exit’ splitfont.c: In function ‘main’: splitfont.c:51:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] 51 | exit(1); | ^~~~ splitfont.c:51:17: note: include ‘’ or provide a declaration of ‘exit’ splitfont.c:56:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] 56 | exit(1); | ^~~~ splitfont.c:56:17: note: include ‘’ or provide a declaration of ‘exit’ splitfont.c:60:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] 60 | exit(1); | ^~~~ splitfont.c:60:17: note: include ‘’ or provide a declaration of ‘exit’ splitfont.c:64:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] 64 | exit(1); | ^~~~ splitfont.c:64:17: note: include ‘’ or provide a declaration of ‘exit’ splitfont.c:69:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] 69 | exit(1); | ^~~~ splitfont.c:69:17: note: include ‘’ or provide a declaration of ‘exit’ splitfont.c:74:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] 74 | exit(1); | ^~~~ splitfont.c:74:17: note: include ‘’ or provide a declaration of ‘exit’ splitfont.c:79:29: error: implicit declaration of function ‘strtoul’ [-Wimplicit-function-declaration] 79 | to = from = strtoul(p, &q, 0); | ^~~~~~~ splitfont.c:86:25: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] 86 | exit(1); | ^~~~ splitfont.c:86:25: note: include ‘’ or provide a declaration of ‘exit’ ``` Originally reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075109 --- contrib/splitfont.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/splitfont.c b/contrib/splitfont.c index f27c5b99..d8715bfe 100644 --- a/contrib/splitfont.c +++ b/contrib/splitfont.c @@ -2,6 +2,8 @@ /* this is for iso fonts, no psf header, just 256 characters */ #include +#include +#include #include #include #include