-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of feedparser.NonXMLContentType #171
Labels
Comments
Funnily enough, both NonXMLContentType and CharacterEncodingOverride subclass ThingsNobodyCaresAboutButMe. As a sanity check, it is probably a good idea to skip feeds for which feedparser can't detect a version: >>> f = feedparser.parse('https://www.cockroachlabs.com/blog/index.xml')
>>> f.version
'rss20'
>>> f = feedparser.parse('https://github.com/lemon24/reader/issues/171')
>>> f.version
'' |
lemon24
added a commit
that referenced
this issue
Jun 24, 2020
lemon24
added a commit
that referenced
this issue
Jul 2, 2020
lemon24
added a commit
that referenced
this issue
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://www.cockroachlabs.com/blog/index.xml fails with:
But, the feed does have data:
Could we handle this in a manner similar to CharacterEncodingOverride?
reader/src/reader/_parser.py
Lines 157 to 158 in 3076a57
The text was updated successfully, but these errors were encountered: