From aa7ab9cf845f75d90b96e118d40b1e0a8f94043d Mon Sep 17 00:00:00 2001 From: Emric Pichonnier Date: Tue, 8 Mar 2022 15:38:28 +0100 Subject: [PATCH] fix: Handle 400 and unknown error (#135) --- apps/lenra/lib/lenra/services/openfaas_services.ex | 8 ++++++++ apps/lenra_web/lib/lenra_web/views/error_helpers.ex | 1 + 2 files changed, 9 insertions(+) diff --git a/apps/lenra/lib/lenra/services/openfaas_services.ex b/apps/lenra/lib/lenra/services/openfaas_services.ex index bd9ff7a0..18ad9e59 100644 --- a/apps/lenra/lib/lenra/services/openfaas_services.ex +++ b/apps/lenra/lib/lenra/services/openfaas_services.ex @@ -206,6 +206,10 @@ defmodule Lenra.OpenfaasServices do ) when status_code not in [200, 202] do case status_code do + 400 -> + Logger.error(body) + {:error, :bad_request} + 404 -> Logger.error(body) {:error, :ressource_not_found} @@ -217,6 +221,10 @@ defmodule Lenra.OpenfaasServices do 504 -> Logger.error(body) {:error, :timeout} + + _err -> + Logger.error(body) + {:error, :unknow_error} end end end diff --git a/apps/lenra_web/lib/lenra_web/views/error_helpers.ex b/apps/lenra_web/lib/lenra_web/views/error_helpers.ex index 3277fd35..370750eb 100644 --- a/apps/lenra_web/lib/lenra_web/views/error_helpers.ex +++ b/apps/lenra_web/lib/lenra_web/views/error_helpers.ex @@ -31,6 +31,7 @@ defmodule LenraWeb.ErrorHelpers do no_app_found: %{code: 21, message: "No application found for the current link."}, environement_not_build: %{code: 22, message: "This application was not yet build."}, widget_not_found: %{code: 23, message: "No Widget found in app manifest. This should not happen."}, + bad_request: %{code: 400, message: "Server cannot understand or process the request due to a client-side error."}, error_404: %{code: 404, message: "Not Found."}, error_500: %{code: 500, message: "Internal server error."}, openfaas_not_reachable: %{code: 1000, message: "Openfaas is not accessible"},