Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't depend on unordered object #393

Merged
merged 2 commits into from
Dec 27, 2014
Merged

Don't depend on unordered object #393

merged 2 commits into from
Dec 27, 2014

Commits on Dec 26, 2014

  1. Don't depend on unordered object 

    Before, passing `range` as `{min: 1, max: 5, 25%: 2, 50%: 3}` and `{min: 1, 25%: 2, 50%: 3, max: 5}` would mean different results.
Because objects are not guaranteed to return keys in same order, 2 resulting number arrays need to be sorted.
    @falsefalse
    falsefalse committed Dec 26, 2014
    Configuration menu
    Copy the full SHA
    fa1b60a View commit details
    Browse the repository at this point in the history

  2. Unorderness of a range object won't affect slider 

    Turn range into array, sort it by value and use then.
This makes sure that all 4 arrays are naturally ordered the same way.
    @falsefalse
    falsefalse committed Dec 26, 2014
    Configuration menu
    Copy the full SHA
    6ce02c7 View commit details
    Browse the repository at this point in the history