Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): add Divider component #52

Merged
merged 4 commits into from
Jul 5, 2022
Merged

feat(component): add Divider component #52

merged 4 commits into from
Jul 5, 2022

Conversation

niloysikdar
Copy link
Member

@niloysikdar niloysikdar commented Jul 3, 2022 •
edited
Loading

This Pull Request covers:

  • New component Divider
  • Stories for newly added component
  • Props for the component
export interface BaseStyleProp<T extends string> {
  classes?: Partial<Record<T, CSSProperties>>;
  className?: string;
}

export interface DividerProps extends BaseStyleProp<DividerStyles> {
  align?: 'left' | 'center' | 'right';
}

Resolves #44

Signed-off-by: Niloy Sikdar niloysikdar30@gmail.com

@niloysikdar
feat(component): add divider component
15002b1 
add new Divider component

resolves #44

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar
docs(storybook): add stories for divider
f81fd69 
add new stories for new Divider component

resolves #44

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Jul 3, 2022
@niloysikdar niloysikdar marked this pull request as ready for review July 5, 2022 17:02
agentmilindu
agentmilindu requested changes Jul 5, 2022
View reviewed changes
src/components/Divider/Divider.stories.tsx Outdated Show resolved Hide resolved
src/components/Divider/Divider.stories.tsx Outdated Show resolved Hide resolved
src/components/Divider/Divider.stories.tsx Outdated Show resolved Hide resolved
@niloysikdar
fix(component): fix Divider component
ac806d9 
fix Divider component structure to use hr and update the stories

resolves #44

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar force-pushed the feat/44-add-component-divider branch from 9bcfb46 to ac806d9 Compare July 5, 2022 17:49
@agentmilindu agentmilindu merged commit eb301f4 into main Jul 5, 2022
@agentmilindu agentmilindu deleted the feat/44-add-component-divider branch July 5, 2022 17:55
github-actions bot pushed a commit that referenced this pull request Jul 5, 2022
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
7633168 
# [1.3.0](v1.2.1...v1.3.0) (2022-07-05)

### Features

* **component:** add Divider component ([#52](#52)) ([eb301f4](eb301f4)), closes [#44](#44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agentmilindu agentmilindu Awaiting requested review from agentmilindu

Assignees
No one assigned
Labels
GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add component: Divider
2 participants
@niloysikdar @agentmilindu