Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the exported packages #75

Closed
niloysikdar opened this issue Aug 6, 2022 · 1 comment · Fixed by #80
Closed

Optimize the exported packages #75

niloysikdar opened this issue Aug 6, 2022 · 1 comment · Fixed by #80
Assignees
@niloysikdar
Labels
1 1 story point GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released
Milestone
GSoC 2022 - Sprint H

Comments

@niloysikdar
Copy link
Member

niloysikdar commented Aug 6, 2022 •
edited
Loading

Description:

  • Currently, our package also contains a few tests and storybook stories for the components and methods after the build process.
  • We can remove those files from the final production package as there are just for testing and they are of no use, and these are only increasing the size of the package.

Outcome:

  • Removing all tests and stories from the final package.

Proposed Solution:

  • We can add this config inside our tsconfig.json to exclude those files while building the package

    "exclude": ["node_modules", "**/*.test.ts", "**/*.test.tsx", "**/*.stories.ts", "**/*.stories.tsx"]
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Aug 6, 2022
@niloysikdar niloysikdar added this to the GSoC 2022 - Sprint H milestone Aug 6, 2022
@niloysikdar niloysikdar moved this to Todo in React Email Aug 6, 2022
@niloysikdar niloysikdar self-assigned this Aug 6, 2022
niloysikdar added a commit that referenced this issue Aug 6, 2022
@niloysikdar
perf(tsconfig): fix tsconfig
e02f6df 
Improve tsconfig to remove all tests and stories from the final package

Resolves #75

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar mentioned this issue Aug 6, 2022
Merged
@niloysikdar niloysikdar moved this from Todo to In Progress in React Email Aug 6, 2022
agentmilindu pushed a commit that referenced this issue Aug 7, 2022
@niloysikdar
perf(tsconfig): fix tsconfig (#80)
e370c09 
Improve tsconfig to remove all tests and stories from the final package

Resolves #75

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
Repository owner moved this from In Progress to Done in React Email Aug 7, 2022
github-actions bot pushed a commit that referenced this issue Aug 7, 2022
@semantic-release-bot
chore(release): 1.8.0 [skip ci]
f2cbf8d 
# [1.8.0](v1.7.1...v1.8.0) (2022-08-07)

### Features

* **example:** add example for ESM ([#79](#79)) ([c7e04f8](c7e04f8)), closes [#72](#72)

### Performance Improvements

* **tsconfig:** fix tsconfig ([#80](#80)) ([e370c09](e370c09)), closes [#75](#75)
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

🎉 This PR is included in version 1.8.0 🎉

@niloysikdar niloysikdar added the 1 1 story point label Aug 7, 2022
@agentmilindu agentmilindu moved this from Done to Released in React Email Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
1 1 story point GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released
Projects
React Email
Status: Released
Milestone
GSoC 2022 - Sprint H
Development

Successfully merging a pull request may close this issue.

perf(tsconfig): fix tsconfig leopardslab/react-email
1 participant
@niloysikdar