Http conversions #26
Http conversions #26
Conversation
This allows reqwest_mock to be used with http-using APIs rather than forcing the entire API stack to use the types in this crate.
| impl<T> From<HttpRequest<T>> for Request where T: Into<Body> { | ||
| fn from(r: HttpRequest<T>) -> Self { | ||
| let header = RequestHeader { | ||
| url: Url::parse(&format!("{}", r.uri())).unwrap(), |
There was a problem hiding this comment.
I will merge your PR but I'll add a note here that this should be better handled in the future. (Invalid urls could be used as an exploit to make a software panic, but it's not like the crate is security oriented to begin with.)
Also see: seanmonstar/reqwest#668
There was a problem hiding this comment.
That issue is about the other direction, but I'd not be surprised if this way also had parsing disagreements. Unfortunately, there doesn't seem any work going on to make a unified url crate that http is willing to use (builder pattern in use, HTTP2 breakdown and relative path support), so we're stuck with these conversion warts.
hyperium/http#396 hyperium/http#277 (points to servo/rust-url#468) hyperium/http#137 hyperium/http#73
Depends on #25.