From 96d10c09cc79d56cddd711f232a97ca4d910f172 Mon Sep 17 00:00:00 2001
From: koal44 <random.var.ny@gmail.com>
Date: Thu, 14 Mar 2024 04:45:44 -0700
Subject: [PATCH] Implement the GridView feature by binding directly to the
 View property.

Removed the custom class ui:ListView as its purpose was to expose the ViewState, which can be simplified by directly binding to ListView.View with a ValueConverter.
---
 .../ViewModels/Windows/MainWindowViewModel.cs |  2 +-
 .../Views/Pages/Collections/ListViewPage.xaml | 12 ++--
 .../SyntaxHighlight.xaml                      |  2 +-
 .../AutoSuggestBox/AutoSuggestBox.xaml        |  4 +-
 src/Wpf.Ui/Controls/ListView/ListView.cs      | 65 -------------------
 src/Wpf.Ui/Controls/ListView/ListView.xaml    | 25 +++----
 .../Controls/ListView/ListViewItem.xaml       | 12 +++-
 .../ViewToListViewViewStateConverter.cs       | 28 ++++++++
 8 files changed, 61 insertions(+), 89 deletions(-)
 delete mode 100644 src/Wpf.Ui/Controls/ListView/ListView.cs
 create mode 100644 src/Wpf.Ui/Converters/ViewToListViewViewStateConverter.cs

diff --git a/src/Wpf.Ui.Gallery/ViewModels/Windows/MainWindowViewModel.cs b/src/Wpf.Ui.Gallery/ViewModels/Windows/MainWindowViewModel.cs
index 43531e71d..7e96e95c5 100644
--- a/src/Wpf.Ui.Gallery/ViewModels/Windows/MainWindowViewModel.cs
+++ b/src/Wpf.Ui.Gallery/ViewModels/Windows/MainWindowViewModel.cs
@@ -72,7 +72,7 @@ public partial class MainWindowViewModel : ObservableObject
             {
                 new NavigationViewItem(nameof(System.Windows.Controls.DataGrid), typeof(DataGridPage)),
                 new NavigationViewItem(nameof(ListBox), typeof(ListBoxPage)),
-                new NavigationViewItem(nameof(Ui.Controls.ListView), typeof(ListViewPage)),
+                new NavigationViewItem(nameof(ListView), typeof(ListViewPage)),
                 new NavigationViewItem(nameof(TreeView), typeof(TreeViewPage)),
 #if DEBUG
                 new NavigationViewItem("TreeList", typeof(TreeListPage)),
diff --git a/src/Wpf.Ui.Gallery/Views/Pages/Collections/ListViewPage.xaml b/src/Wpf.Ui.Gallery/Views/Pages/Collections/ListViewPage.xaml
index 7ce461c3d..a9a6f6e48 100644
--- a/src/Wpf.Ui.Gallery/Views/Pages/Collections/ListViewPage.xaml
+++ b/src/Wpf.Ui.Gallery/Views/Pages/Collections/ListViewPage.xaml
@@ -30,7 +30,7 @@
                 \t&lt;/ListView.ItemTemplate&gt;\n
                 &lt;/ListView&gt;
             </controls:ControlExample.XamlCode>
-            <ui:ListView
+            <ListView
                 MaxHeight="200"
                 d:ItemsSource="{d:SampleData ItemCount=2}"
                 ItemsSource="{Binding ViewModel.BasicListViewItems, Mode=TwoWay}"
@@ -41,7 +41,7 @@
                         <TextBlock Margin="8,4" Text="{Binding Name, Mode=OneWay}" />
                     </DataTemplate>
                 </ListView.ItemTemplate>
-            </ui:ListView>
+            </ListView>
         </controls:ControlExample>
 
         <controls:ControlExample Margin="0,36,0,0" HeaderText="ListView with Selection Support.">
@@ -59,7 +59,7 @@
                     <ColumnDefinition Width="*" />
                     <ColumnDefinition Width="Auto" />
                 </Grid.ColumnDefinitions>
-                <ui:ListView
+                <ListView
                     Grid.Column="0"
                     MaxHeight="200"
                     d:ItemsSource="{d:SampleData ItemCount=2}"
@@ -101,7 +101,7 @@
                             </Grid>
                         </DataTemplate>
                     </ListView.ItemTemplate>
-                </ui:ListView>
+                </ListView>
                 <StackPanel
                     Grid.Column="1"
                     MinWidth="120"
@@ -129,7 +129,7 @@
                 \t&lt;/ListView.View&gt;\n
                 &lt;/ListView&gt;
             </controls:ControlExample.XamlCode>
-            <ui:ListView
+            <ListView
                 MaxHeight="200"
                 d:ItemsSource="{d:SampleData ItemCount=3}"
                 BorderThickness="0"
@@ -147,7 +147,7 @@
                         <GridViewColumn DisplayMemberBinding="{Binding Company}" Header="Company" />
                     </GridView>
                 </ListView.View>
-            </ui:ListView>
+            </ListView>
         </controls:ControlExample>
     </StackPanel>
 </Page>
diff --git a/src/Wpf.Ui.SyntaxHighlight/SyntaxHighlight.xaml b/src/Wpf.Ui.SyntaxHighlight/SyntaxHighlight.xaml
index 88d284dcf..279e1d3ef 100644
--- a/src/Wpf.Ui.SyntaxHighlight/SyntaxHighlight.xaml
+++ b/src/Wpf.Ui.SyntaxHighlight/SyntaxHighlight.xaml
@@ -8,7 +8,7 @@
 <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
 
     <!--  https://github.com/tonsky/FiraCode  -->
-    <FontFamily x:Key="FiraCode">pack://application:,,,/Wpf.Ui.SyntaxHighlight;component/Fonts/#Fira Code</FontFamily>
+    <FontFamily x:Key="FiraCode">pack://application:,,,/Wpf.Ui;component/Fonts/#Fira Code</FontFamily>
 
     <ResourceDictionary.MergedDictionaries>
         <ResourceDictionary Source="pack://application:,,,/Wpf.Ui.SyntaxHighlight;component/Controls/CodeBlock.xaml" />
diff --git a/src/Wpf.Ui/Controls/AutoSuggestBox/AutoSuggestBox.xaml b/src/Wpf.Ui/Controls/AutoSuggestBox/AutoSuggestBox.xaml
index ec3330535..d6c8aa11a 100644
--- a/src/Wpf.Ui/Controls/AutoSuggestBox/AutoSuggestBox.xaml
+++ b/src/Wpf.Ui/Controls/AutoSuggestBox/AutoSuggestBox.xaml
@@ -144,7 +144,7 @@
                                 BorderThickness="1"
                                 CornerRadius="8"
                                 SnapsToDevicePixels="True">
-                                <controls:ListView
+                                <ListView
                                     x:Name="PART_SuggestionsList"
                                     MaxHeight="{TemplateBinding MaxSuggestionListHeight}"
                                     DisplayMemberPath="{TemplateBinding DisplayMemberPath}"
@@ -162,7 +162,7 @@
                                                 VirtualizationMode="Recycling" />
                                         </ItemsPanelTemplate>
                                     </ListView.ItemsPanel>
-                                </controls:ListView>
+                                </ListView>
                             </Border>
                         </Popup>
                     </Grid>
diff --git a/src/Wpf.Ui/Controls/ListView/ListView.cs b/src/Wpf.Ui/Controls/ListView/ListView.cs
deleted file mode 100644
index 44efcd2a9..000000000
--- a/src/Wpf.Ui/Controls/ListView/ListView.cs
+++ /dev/null
@@ -1,65 +0,0 @@
-namespace Wpf.Ui.Controls;
-
-public class ListView : System.Windows.Controls.ListView
-{
-    public ListViewViewState ViewState
-    {
-        get => (ListViewViewState)GetValue(ViewStateProperty);
-        set => SetValue(ViewStateProperty, value);
-    }
-
-    /// <summary>Identifies the <see cref="ViewState"/> dependency property.</summary>
-    public static readonly DependencyProperty ViewStateProperty = DependencyProperty.Register(nameof(ViewState), typeof(ListViewViewState), typeof(ListView), new FrameworkPropertyMetadata(ListViewViewState.Default, OnViewStateChanged));
-
-    private static void OnViewStateChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
-    {
-        if (d is not ListView self)
-        {
-            return;
-        }
-
-        self.OnViewStateChanged(e);
-    }
-
-    protected virtual void OnViewStateChanged(DependencyPropertyChangedEventArgs e)
-    {
-        // derived classes can hook `ViewState` property changes by overriding this method
-    }
-
-    public ListView()
-    {
-        Loaded += OnLoaded;
-    }
-
-    private void OnLoaded(object sender, RoutedEventArgs e)
-    {
-        // immediately unsubscribe to prevent memory leaks
-        Loaded -= OnLoaded;
-
-        // get the descriptor for the `View` property since the framework doesn't provide a public hook for it
-        var descriptor = DependencyPropertyDescriptor.FromProperty(System.Windows.Controls.ListView.ViewProperty, typeof(System.Windows.Controls.ListView));
-        descriptor?.AddValueChanged(this, OnViewPropertyChanged);
-        UpdateViewState(); // set the initial state
-    }
-
-    private void OnViewPropertyChanged(object? sender, EventArgs e)
-    {
-        UpdateViewState();
-    }
-
-    private void UpdateViewState()
-    {
-        ListViewViewState viewState = View switch
-        {
-            System.Windows.Controls.GridView => ListViewViewState.GridView,
-            null => ListViewViewState.Default,
-            _ => ListViewViewState.Default
-        };
-        SetCurrentValue(ViewStateProperty, viewState);
-    }
-
-    static ListView()
-    {
-        DefaultStyleKeyProperty.OverrideMetadata(typeof(ListView), new FrameworkPropertyMetadata(typeof(ListView)));
-    }
-}
diff --git a/src/Wpf.Ui/Controls/ListView/ListView.xaml b/src/Wpf.Ui/Controls/ListView/ListView.xaml
index 238a25c9c..3cc76c08d 100644
--- a/src/Wpf.Ui/Controls/ListView/ListView.xaml
+++ b/src/Wpf.Ui/Controls/ListView/ListView.xaml
@@ -8,9 +8,12 @@
 <ResourceDictionary
     xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
     xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-    xmlns:controls="clr-namespace:Wpf.Ui.Controls">
+    xmlns:controls="clr-namespace:Wpf.Ui.Controls"
+    xmlns:converters="clr-namespace:Wpf.Ui.Converters">
 
-    <ControlTemplate x:Key="NullViewTemplate" TargetType="{x:Type controls:ListView}">
+    <converters:ViewToListViewViewStateConverter x:Key="ViewToListViewViewStateConverter" />
+
+    <ControlTemplate x:Key="NullViewTemplate" TargetType="{x:Type ListView}">
         <Grid>
             <controls:PassiveScrollViewer
                 x:Name="PART_ContentHost"
@@ -134,7 +137,7 @@
         </Setter>
     </Style>
 
-    <ControlTemplate x:Key="GridViewTemplate" TargetType="{x:Type controls:ListView}">
+    <ControlTemplate x:Key="GridViewTemplate" TargetType="{x:Type ListView}">
         <Border
             Name="Bd"
             Background="Transparent"
@@ -155,18 +158,18 @@
         </ControlTemplate.Triggers>
     </ControlTemplate>
 
-    <Style x:Key="ListViewStyle" TargetType="{x:Type controls:ListView}">
+    <Style x:Key="ListViewStyle" TargetType="{x:Type ListView}">
+        <Setter Property="Margin" Value="0" />
+        <Setter Property="Padding" Value="0" />
         <Setter Property="ScrollViewer.VerticalScrollBarVisibility" Value="Auto" />
         <Setter Property="ScrollViewer.HorizontalScrollBarVisibility" Value="Auto" />
         <Setter Property="ScrollViewer.CanContentScroll" Value="True" />
-        <Setter Property="Control.VerticalContentAlignment" Value="Center" />
-        <Setter Property="Margin" Value="0" />
-        <Setter Property="Padding" Value="0" />
-        <Setter Property="SnapsToDevicePixels" Value="True" />
+        <Setter Property="VerticalContentAlignment" Value="Center" />
         <Setter Property="VirtualizingPanel.IsVirtualizing" Value="True" />
         <Setter Property="VirtualizingPanel.VirtualizationMode" Value="Standard" />
+        <Setter Property="SnapsToDevicePixels" Value="True" />
         <Style.Triggers>
-            <DataTrigger Binding="{Binding Path=ViewState, RelativeSource={RelativeSource Mode=Self}}" Value="{x:Static controls:ListViewViewState.Default}">
+            <DataTrigger Binding="{Binding Path=View, RelativeSource={RelativeSource Mode=Self}, Converter={StaticResource ViewToListViewViewStateConverter}}" Value="{x:Static controls:ListViewViewState.Default}">
                 <Setter Property="ItemsPanel">
                     <Setter.Value>
                         <ItemsPanelTemplate>
@@ -176,12 +179,12 @@
                 </Setter>
                 <Setter Property="Template" Value="{DynamicResource NullViewTemplate}" />
             </DataTrigger>
-            <DataTrigger Binding="{Binding Path=ViewState, RelativeSource={RelativeSource Mode=Self}}" Value="{x:Static controls:ListViewViewState.GridView}">
+            <DataTrigger Binding="{Binding Path=View, RelativeSource={RelativeSource Mode=Self}, Converter={StaticResource ViewToListViewViewStateConverter}}" Value="{x:Static controls:ListViewViewState.GridView}">
                 <Setter Property="Template" Value="{DynamicResource GridViewTemplate}" />
             </DataTrigger>
         </Style.Triggers>
     </Style>
 
-    <Style BasedOn="{StaticResource ListViewStyle}" TargetType="{x:Type controls:ListView}" />
+    <Style BasedOn="{StaticResource ListViewStyle}" TargetType="{x:Type ListView}" />
 
 </ResourceDictionary>
diff --git a/src/Wpf.Ui/Controls/ListView/ListViewItem.xaml b/src/Wpf.Ui/Controls/ListView/ListViewItem.xaml
index 8b0e66ef9..30a8d7d68 100644
--- a/src/Wpf.Ui/Controls/ListView/ListViewItem.xaml
+++ b/src/Wpf.Ui/Controls/ListView/ListViewItem.xaml
@@ -5,7 +5,13 @@
     All Rights Reserved.
 -->
 
-<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
+<ResourceDictionary
+    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
+    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+    xmlns:controls="clr-namespace:Wpf.Ui.Controls"
+    xmlns:converters="clr-namespace:Wpf.Ui.Converters">
+
+    <converters:ViewToListViewViewStateConverter x:Key="ViewToListViewViewStateConverter" />
 
     <ControlTemplate x:Key="NullViewItemTemplate" TargetType="{x:Type ListViewItem}">
         <Border
@@ -95,10 +101,10 @@
         <Setter Property="Margin" Value="0,0,0,2" />
         <Setter Property="Padding" Value="4" />
         <Style.Triggers>
-            <DataTrigger Binding="{Binding Path=ViewState, RelativeSource={RelativeSource AncestorType={x:Type ListView}}}" Value="Default">
+            <DataTrigger Binding="{Binding Path=View, RelativeSource={RelativeSource AncestorType={x:Type ListView}}, Converter={StaticResource ViewToListViewViewStateConverter}}" Value="{x:Static controls:ListViewViewState.Default}">
                 <Setter Property="Template" Value="{DynamicResource NullViewItemTemplate}" />
             </DataTrigger>
-            <DataTrigger Binding="{Binding Path=ViewState, RelativeSource={RelativeSource AncestorType={x:Type ListView}}}" Value="GridView">
+            <DataTrigger Binding="{Binding Path=View, RelativeSource={RelativeSource AncestorType={x:Type ListView}}, Converter={StaticResource ViewToListViewViewStateConverter}}" Value="{x:Static controls:ListViewViewState.GridView}">
                 <Setter Property="Template" Value="{DynamicResource GridViewItemTemplate}" />
             </DataTrigger>
         </Style.Triggers>
diff --git a/src/Wpf.Ui/Converters/ViewToListViewViewStateConverter.cs b/src/Wpf.Ui/Converters/ViewToListViewViewStateConverter.cs
new file mode 100644
index 000000000..88a8bc429
--- /dev/null
+++ b/src/Wpf.Ui/Converters/ViewToListViewViewStateConverter.cs
@@ -0,0 +1,28 @@
+// This Source Code Form is subject to the terms of the MIT License.
+// If a copy of the MIT was not distributed with this file, You can obtain one at https://opensource.org/licenses/MIT.
+// Copyright (C) Leszek Pomianowski and WPF UI Contributors.
+// All Rights Reserved.
+
+using System.Windows.Controls;
+using System.Windows.Data;
+using Wpf.Ui.Controls;
+
+namespace Wpf.Ui.Converters;
+
+internal class ViewToListViewViewStateConverter : IValueConverter
+{
+    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        return value switch
+        {
+            GridView => ListViewViewState.GridView,
+            null => ListViewViewState.Default,
+            _ => ListViewViewState.Default
+        };
+    }
+
+    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        throw new NotSupportedException("Converting from ListViewViewState to View is not supported.");
+    }
+}