Allow opt in logins to be case insensitive #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerebear
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Thank you for this fix @Hkly! It looks good to me, but you will need to run npm run all and commit the results as per these instructions in order to fix the build.
Update main.test.ts for case insensitivity
|
@lerebear ah thank you! I was scanning for |
Oh, I only just added that section in response to this PR actually 😄. I should probably come up with clearer contribution guidelines soon. In any case, thank you again! |
lerebear
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #51
This PR updates the comparison between the logins in the optIns config and the PR author to be case insensitive. Also hopefully adds the right kind of test for this.