-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add POST route for testing tool execution via tool_id
#2139
Conversation
letta/server/server.py
Outdated
agent_state = None | ||
|
||
try: | ||
sandbox_run_result = ToolExecutionSandbox(tool.name, tool_args_dict, user_id).run(agent_state=agent_state) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit of a bit, but can't this be the same code as run_tool_from_source
once the Tool
object is ready?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah this code I kind of stopped editing in the PR since I wasn't sure if we wanted to delete it?
e.g. if we're not going to use run_tool
and only use run_tool_from_source
, shouldn't we just add the later and kill the former (and add it if we need it later?)
Example tests: