diff --git a/src/main/java/com/spotify/docker/BuildMojo.java b/src/main/java/com/spotify/docker/BuildMojo.java index 6f2044fdc..d300cf837 100644 --- a/src/main/java/com/spotify/docker/BuildMojo.java +++ b/src/main/java/com/spotify/docker/BuildMojo.java @@ -161,6 +161,10 @@ public class BuildMojo extends AbstractDockerMojo { private List runList; + /** Flag to squash all run commands into one layer. Defaults to false. */ + @Parameter(property = "squashRunCommands", defaultValue = "false") + private boolean squashRunCommands; + /** All resources will be copied to this directory before building the image. */ @Parameter(property = "project.build.directory") protected String buildDirectory; @@ -568,8 +572,12 @@ private void createDockerFile(final String directory, final List filesTo } if (runList != null && !runList.isEmpty()) { - for (final String run : runList) { - commands.add("RUN " + run); + if (squashRunCommands) { + commands.add("RUN " + Joiner.on(" &&\\\n\t").join(runList)); + } else { + for (final String run : runList) { + commands.add("RUN " + run); + } } } diff --git a/src/test/java/com/spotify/docker/BuildMojoTest.java b/src/test/java/com/spotify/docker/BuildMojoTest.java index 254f0e4bc..be354f16e 100644 --- a/src/test/java/com/spotify/docker/BuildMojoTest.java +++ b/src/test/java/com/spotify/docker/BuildMojoTest.java @@ -103,6 +103,22 @@ public class BuildMojoTest extends AbstractMojoTestCase { "VOLUME /example2" ); + private static final List GENERATED_DOCKERFILE_WITH_SQUASH_COMMANDS = Arrays.asList( + "FROM busybox", + "MAINTAINER user", + "ENV FOO BAR", + "WORKDIR /opt/app", + "ADD resources/parent/child/child.xml resources/parent/child/", + "ADD resources/parent/parent.xml resources/parent/", + "ADD copy2.json .", + "RUN ln -s /a /b &&\\", + "\twget 127.0.0.1:8080", + "EXPOSE 8080 8081", + "USER app", + "ENTRYPOINT date", + "CMD [\"-u\"]" + ); + private static final List PROFILE_GENERATED_DOCKERFILE = Arrays.asList( "FROM busybox", "ENV APP_NAME FOOBAR", @@ -268,6 +284,22 @@ public void testBuildWithGeneratedDockerfile() throws Exception { Files.readAllLines(Paths.get("target/docker/Dockerfile"), UTF_8)); } + public void testBuildWithGeneratedDockerfileWithSquashCommands() throws Exception { + final File pom = getTestFile("src/test/resources/pom-build-generated-dockerfile-with-squash-commands.xml"); + assertNotNull("Null pom.xml", pom); + assertTrue("pom.xml does not exist", pom.exists()); + + final BuildMojo mojo = setupMojo(pom); + final DockerClient docker = mock(DockerClient.class); + mojo.execute(docker); + + verify(docker).build(eq(Paths.get("target/docker")), eq("busybox"), + any(AnsiProgressHandler.class)); + assertFilesCopied(); + assertEquals("wrong dockerfile contents", GENERATED_DOCKERFILE_WITH_SQUASH_COMMANDS, + Files.readAllLines(Paths.get("target/docker/Dockerfile"), UTF_8)); + } + public void testBuildGeneratedDockerFile_CopiesEntireDirectory() throws Exception { final File pom = getTestFile("src/test/resources/pom-build-copy-entire-directory.xml"); diff --git a/src/test/resources/pom-build-generated-dockerfile-with-squash-commands.xml b/src/test/resources/pom-build-generated-dockerfile-with-squash-commands.xml new file mode 100644 index 000000000..176af0907 --- /dev/null +++ b/src/test/resources/pom-build-generated-dockerfile-with-squash-commands.xml @@ -0,0 +1,60 @@ + + + 4.0.0 + + Docker Maven Plugin Test Pom + com.spotify + docker-maven-plugin-test + 0.0.1-SNAPSHOT + jar + + + + + com.spotify + docker-maven-plugin + 0.1-SNAPSHOT + + + busybox + user + http://host:2375 + busybox + date + + BAR + + + 8081 + 8080 + + -u + + + + + + resources + src/test/resources/copy1 + **/*.xml + **/*exclude* + + + + src/test/resources/copy2 + + + + ln -s /a /b + wget 127.0.0.1:8080 + + true + /opt/app + app + + + + +