Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivate API Platform automatic integration #1118

Closed
jonag opened this issue Feb 18, 2023 · 1 comment · Fixed by #1119
Closed

Deactivate API Platform automatic integration #1118

jonag opened this issue Feb 18, 2023 · 1 comment · Fixed by #1119

Comments

@jonag
Copy link

jonag commented Feb 18, 2023

Hello,

Since the version 2.18.0 the API Platform integration is automatically enabled if the bundle detects that API Platform is installed.

This is a great addition and should work for most projects, but can also cause some issue is some specific case. For example I'm using split cookies and have handcrafted my own definition for the API login operation. So after the update, I now have in the documentation page two definitions for the login route: mine and the one autogenerated (with a wrong definition).

Is there a way to deactive the automatic integration (I didn't find any) or would you consider a PR to allow that? If so, what whould be the best approach? Adding a new parameter under lexik_jwt_authentication.api_platform or something else?

Thank you!
@chalasr
Copy link
Collaborator

chalasr commented Feb 19, 2023

Looks like we totally forgot to care about BC here, sorry for this! It should definitely be fixed

@maxhelias maxhelias mentioned this issue Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix API Platform integration maxhelias/LexikJWTAuthenticationBundle
2 participants
@jonag @chalasr