add support for OTP-24 #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`:crypto.hmac/3` was removed in favor of `:crypto.mac/4` which was added to in OTP 22.1. This patch keeps the compatibility with OTP < 22.1 by checking if `:crypto.mac/4` is available.
Closed
|
Thank you @tobstarr, this will unblock our use of ExTwitter on OTP 24! |
|
I would love to see this merged too. I'm blocked on finishing the ExTwitter project, running through the Getting Started with Elixir course on pluralsight. |
hashrocketeer
added a commit
to hashrocket/tilex
that referenced
this pull request
Aug 6, 2021
The newest versions of OTP do not have `:crypto.hmac/3` anymore and this has broken TIL integration with Twitter since the last big app bump to use OTP 24. `extwitter` library uses `oauther` which does not have changed the `:crypto.mac/4` yet, so we're going to use this hot fix branch for now. For reference: lexmag/oauther#22 parroty/extwitter#140
1 task
hashrocketeer
added a commit
to hashrocket/tilex
that referenced
this pull request
Aug 6, 2021
The newest versions of OTP do not have `:crypto.hmac/3` anymore and this has broken TIL integration with Twitter since the last big app bump to use OTP 24. `extwitter` library uses `oauther` which does not have changed the `:crypto.mac/4` yet, so we're going to use this hot fix branch for now. For reference: lexmag/oauther#22 parroty/extwitter#140
hashrocketeer
added a commit
to hashrocket/tilex
that referenced
this pull request
Aug 6, 2021
The newest versions of OTP do not have `:crypto.hmac/3` anymore and this has broken TIL integration with Twitter since the last big app bump to use OTP 24. `extwitter` library uses `oauther` which does not have changed the `:crypto.mac/4` yet, so we're going to use this hot fix branch for now. For reference: lexmag/oauther#22 parroty/extwitter#140
|
Any updates on this @lexmag? |
|
If you don't mind a butt ton of errors @stevenpdq , @TheFirstAvenger |
hashrocketeer
added a commit
to hashrocket/tilex
that referenced
this pull request
Aug 24, 2021
The newest versions of OTP do not have `:crypto.hmac/3` anymore and this has broken TIL integration with Twitter since the last big app bump to use OTP 24. `extwitter` library uses `oauther` which does not have changed the `:crypto.mac/4` yet, so we're going to use this hot fix branch for now. For reference: lexmag/oauther#22 parroty/extwitter#140
|
This PR is no longer needed since #24 was merged. |
|
This patch has been merged as part of #24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:crypto.hmac/3was removed in favor of:crypto.mac/4which was added to in OTP 22.1.This patch keeps the compatibility with OTP < 22.1 by checking if
:crypto.mac/4is available.