Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked Group Items Potential Issue Fix #48

Closed
sjbeatle opened this issue Jan 17, 2015 · 2 comments
Closed

Stacked Group Items Potential Issue Fix #48

sjbeatle opened this issue Jan 17, 2015 · 2 comments

Comments

@sjbeatle
Copy link

First, fantastic plugin! Kudos!

Something I noticed was that when reducing the screen width to the point where all items in a group were stacked on top of each other (essentially single item rows), the height would continue to be set to whatever the last value was prior to being stacked.

I believe the issue can be fixed by changing the code on lines 201-203 from this:
// skip apply to rows with only one item
if (opts.byRow && $row.length <= 1)
return;

To something more like this (I'm sure you'll know a better way to implement this, pardon my crude coding):
// set item height to auto for rows with only one item
if (opts.byRow && $row.length <= 1) {
$(this).css('height','auto');
return;
}

Thanks again, maybe this enhancement can make an already amazing plugin just a teeny bit better.

~Steve

@liabru liabru closed this as completed in 64b9a54 Jan 17, 2015
@liabru
Copy link
Owner

liabru commented Jan 17, 2015

Well spotted, thank you for reporting this!

@sjbeatle
Copy link
Author

Sweet! My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants