-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
Hey @sideeffffect, thanks for the PR. However, this would be a breaking behavior change and may break a lot of projects' CI builds. In fact, I'm surprised that IntelliJ made this change due to similar reasons. Especially, I don't see the new order is so much better than the existing one and worth a breaking behavior change. BTW, where can I find the announcement? My IntelliJ IDEA 2020.3 still uses the old order. |
https://blog.jetbrains.com/scala/2020/11/26/enhanced-package-prefixes/
|
@liancheng you are the I just know that, from my own experience and seeing others use it, that being different from IDEA (which is what most people use) is causing grief too. You either have to customize I was thinking that IDEA changing it's default scheme could be a good opportunity for (@jastice are you guys planing any further changes to the order of Scala imports?) Ultimately, this is your decision to make, of course 👍 |
Hey @sideeffffect, sorry for the late reply, and thanks as always for your input! I'm convinced that lowering the migration cost of IntelliJ users is more important, especially when this project is still young and far from 1.0. Changing the default groups also requires updating the doc and test cases, I can work on that. |
0fabad0
to
ea595e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 4 4
Lines 242 242
Branches 12 12
=======================================
Hits 220 220
Misses 22 22
Continue to review full report at Codecov.
|
I've updated the documentation and fixed the tests. |
Thank you, merging! |
IntelliJ IDEA has recently changed the default order of import blocks. Would you @liancheng consider changing to the new scheme?
Since IDEA is the most used Scala IDE, it would make life much simpler for the majority of
scalafix-organize-imports
users.