From 59fba56eb50089bdf77424753a56e08716c01327 Mon Sep 17 00:00:00 2001 From: Edward Thomson Date: Wed, 30 May 2018 00:06:02 +0100 Subject: [PATCH 1/2] Update libgit2 to v0.27.1 (b0d9952) --- LibGit2Sharp/LibGit2Sharp.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LibGit2Sharp/LibGit2Sharp.csproj b/LibGit2Sharp/LibGit2Sharp.csproj index fc15f0e2f..6e966a5c9 100644 --- a/LibGit2Sharp/LibGit2Sharp.csproj +++ b/LibGit2Sharp/LibGit2Sharp.csproj @@ -32,7 +32,7 @@ - + From 28a0ab3f09b232f499dcc94656f37c5d118f2db6 Mon Sep 17 00:00:00 2001 From: Edward Thomson Date: Wed, 30 May 2018 00:11:27 +0100 Subject: [PATCH 2/2] Update release notes for v0.25.1 --- CHANGES.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index 6ec51a0e1..c9b6cba42 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -10,6 +10,28 @@ - Windows (x86/amd64): - Linux/Mac OS X: +## v0.25.1 - ([diff](https://github.com/libgit2/libgit2sharp/compare/v0.25..v0.25.1)) + +This is a security release fixing insufficient validation of submodule +names (CVE-2018-11235, reported by Etienne Stalmans) and disallows +`.gitmodules` files as symlinks. This includes [libgit2 +v0.27.1](https://github.com/libgit2/libgit2/releases/tag/v0.27.1), +whose release notes follow. + +While submodule names come from the untrusted `.gitmodules` file, we +blindly append the name to `$GIT_DIR/modules` to construct the final +path of the submodule repository. In case the name contains e.g. `../`, +an adversary would be able to escape your repository and write data at +arbitrary paths. In accordance with git, we now enforce some rules for +submodule names which will cause libgit2 to ignore these malicious names. + +Adding a symlink as .gitmodules into the index from the workdir or +checking out such files is not allowed as this can make a Git +implementation write outside of the repository and bypass the fsck +checks for CVE-2018-11235. + +libgit2 (and LibGit2Sharp) is not susceptible to CVE-2018-11233. + ## v0.25 - ([diff](https://github.com/libgit2/libgit2sharp/compare/v0.24..v0.25)) LibGit2Sharp is now .NET Core 2.0+ and .NET Framework compatible.