Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository.IsValid uses exception for flow control #1816

Open
JonathanDigby1 opened this issue Jul 21, 2020 · 0 comments
Open

Repository.IsValid uses exception for flow control #1816

JonathanDigby1 opened this issue Jul 21, 2020 · 0 comments

Comments

@JonathanDigby1
Copy link

JonathanDigby1 commented Jul 21, 2020

Repository.IsValid uses catching of an Exception to test for validity. This could be considered using exceptions for flow control. It gets annoying for me since I'm checking this often in my application and often the repo isn't there yet so it has a (handled) exception while debugging.
A pull request has been opened to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant