Enables injectable GossipSub router #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Oct 29, 2022
gossipsub.go
Outdated
| @@ -1909,6 +1917,10 @@ func (gs *GossipSubRouter) getPeers(topic string, count int, filter func(peer.ID | |||
| return peers | |||
| } | |||
|
|
|||
| func (gs *GossipSubRouter) WithTagTracerPubsubOption() Option { | |||
There was a problem hiding this comment.
document this please!
Also, lets call it WithDefaultTagTracer.
lthibault
pushed a commit
to lthibault/go-libp2p-pubsub
that referenced
this pull request
Nov 5, 2022
* adds with gossipsub tracker * renames and add godoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an alternative constructor for
GossipSub, which is calledNewGossipSubWithRouter. In contrast to the existingNewGossipSubconstructor that builds aGossipSubinstance with the default router, theNewGossipSubWithRouteralternative is capable of building aGossipSubinstance with arbitraryPubsubRouter. This empowers building more application-specific routers and injecting them intoGossipSub, e.g., the router with an application-specific metric collection.