Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: use a more concrete type to pass muxers to upgrader #1873

Closed
marten-seemann opened this issue Nov 10, 2022 · 0 comments · Fixed by #1885
Closed

config: use a more concrete type to pass muxers to upgrader #1873

marten-seemann opened this issue Nov 10, 2022 · 0 comments · Fixed by #1885
Labels
effort/hours Estimated to take one or several hours kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP

Comments

@marten-seemann
Copy link
Contributor

With #1854, we'll need to pass the muxer along with its ID to the upgrader. This will resolve the potential for confusion in the future here. I suggest merging this PR as is, given that the fix for that issue is imminent.

Originally posted by @marten-seemann in #1858 (comment)
@marten-seemann marten-seemann added kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP effort/hours Estimated to take one or several hours labels Nov 11, 2022
@marten-seemann marten-seemann mentioned this issue Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrader: absorb the muxer_multistream.Transport into the upgrader libp2p/go-libp2p
1 participant
@marten-seemann