Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circuitv2: fix resource accounting when connection upgrading fails #2031

Closed
wants to merge 1 commit into from
Closed

circuitv2: fix resource accounting when connection upgrading fails #2031

wants to merge 1 commit into from

Conversation

marten-seemann
Copy link
Contributor

Very similar to #2015.

@marten-seemann marten-seemann mentioned this pull request Jan 31, 2023
Closed
35 tasks
@MarcoPolo
Copy link
Collaborator

you mean #2025 ?

MarcoPolo
MarcoPolo reviewed Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the missing connScope.Done call?

@marten-seemann
Copy link
Contributor Author

Where is the missing connScope.Done call?

Here:

go-libp2p/p2p/protocol/circuitv2/client/transport.go

Lines 66 to 69 in 34dc115

cc, err := c.upgrader.Upgrade(ctx, c, conn, network.DirOutbound, p, connScope)
if err != nil {
return nil, err
}

@MarcoPolo MarcoPolo mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @MarcoPolo