Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcmgr: Use prometheus SDK for rcmgr metrics #2044

Merged
merged 16 commits into from
Feb 7, 2023

Conversation

MarcoPolo
Copy link
Collaborator

Closes #1955

@marten-seemann
Copy link
Contributor

#2054 introduces a global slice pool for all of our metrics code. Should we merge this one first and rebase this PR? I'm also ok with doing this the other way around, or in a follow-up PR. Your call.

@MarcoPolo
Copy link
Collaborator Author

#2054 introduces a global slice pool for all of our metrics code. Should we merge this one first and rebase this PR? I'm also ok with doing this the other way around, or in a follow-up PR. Your call.

Go ahead and merge that. It's approved. I'll rebase this one. Could you review this one when you get a chance please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rcmgr: Use prometheus for metrics (OpenCensus generates garbage)
2 participants