From 0b77b6943ea943da96f0bb83af3556d0f6cfe342 Mon Sep 17 00:00:00 2001 From: Sahib Yar Date: Sat, 1 Jul 2023 23:27:56 +0500 Subject: [PATCH 1/8] #2364 fix, pushing to try changes in private repo --- .github/actions/go-test-setup/action.yml | 2 +- .../actions/markdown-link-check/action.yml | 20 +++++++++++++++++++ .github/workflows/markdown-links-config.json | 7 +++++++ 3 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 .github/actions/markdown-link-check/action.yml create mode 100644 .github/workflows/markdown-links-config.json diff --git a/.github/actions/go-test-setup/action.yml b/.github/actions/go-test-setup/action.yml index c7e4d11ac5..6980722bb2 100644 --- a/.github/actions/go-test-setup/action.yml +++ b/.github/actions/go-test-setup/action.yml @@ -1,7 +1,7 @@ runs: using: "composite" steps: - - name: increase the UDP receive buffer size # see https://github.com/lucas-clemente/quic-go/wiki/UDP-Receive-Buffer-Size + - name: increase the UDP receive buffer size # see https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes shell: bash run: sysctl -w net.core.rmem_max=2500000 if: ${{ matrix.os == 'ubuntu' }} diff --git a/.github/actions/markdown-link-check/action.yml b/.github/actions/markdown-link-check/action.yml new file mode 100644 index 0000000000..ce1a7b427b --- /dev/null +++ b/.github/actions/markdown-link-check/action.yml @@ -0,0 +1,20 @@ +name: Markdown Links Check + +on: + push: [master] + pull_request: [master] + schedule: + # runs once in a couple of days at 9am + - cron: '0 9 */2 * *' + +jobs: + check-links: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@master + - uses: gaurav-nelson/github-action-markdown-link-check@v1 + with: + use-quiet-mode: 'yes' + use-verbose-mode: 'yes' + # for removing any false positives + config-file: .github/workflows/markdown-links-config.json diff --git a/.github/workflows/markdown-links-config.json b/.github/workflows/markdown-links-config.json new file mode 100644 index 0000000000..e79c8d124d --- /dev/null +++ b/.github/workflows/markdown-links-config.json @@ -0,0 +1,7 @@ +{ + "ignorePatterns": [ + { + "pattern": "^https://github.com/libp2p/go-libp2p/issues/" + } + ] +} \ No newline at end of file From 7981c05b7f2bed6e7821d7ea790d85e51136d90a Mon Sep 17 00:00:00 2001 From: Sahib Yar Date: Sun, 2 Jul 2023 02:55:40 +0500 Subject: [PATCH 2/8] #2364 fixed few issues after running locally by act --- .../action.yml => workflows/link-check.yml} | 0 .github/workflows/markdown-links-config.json | 5 ++++- 2 files changed, 4 insertions(+), 1 deletion(-) rename .github/{actions/markdown-link-check/action.yml => workflows/link-check.yml} (100%) diff --git a/.github/actions/markdown-link-check/action.yml b/.github/workflows/link-check.yml similarity index 100% rename from .github/actions/markdown-link-check/action.yml rename to .github/workflows/link-check.yml diff --git a/.github/workflows/markdown-links-config.json b/.github/workflows/markdown-links-config.json index e79c8d124d..ca43057bef 100644 --- a/.github/workflows/markdown-links-config.json +++ b/.github/workflows/markdown-links-config.json @@ -1,7 +1,10 @@ { "ignorePatterns": [ { - "pattern": "^https://github.com/libp2p/go-libp2p/issues/" + "pattern": "^http://localhost" + }, + { + "pattern": "^gaurav-nelson/" } ] } \ No newline at end of file From f92b090e5c7c476444f57463890a30daadb7ea2a Mon Sep 17 00:00:00 2001 From: Sahib Yar Date: Sun, 2 Jul 2023 12:48:57 +0500 Subject: [PATCH 3/8] #2364 made few other changes --- .github/workflows/link-check.yml | 23 ++++++++++---------- .github/workflows/markdown-links-config.json | 15 +++++++++++++ test-plans/README.md | 2 +- 3 files changed, 28 insertions(+), 12 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index ce1a7b427b..009ad16df1 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -1,20 +1,21 @@ -name: Markdown Links Check - +name: Markdown Link Checking on: - push: [master] - pull_request: [master] - schedule: - # runs once in a couple of days at 9am - - cron: '0 9 */2 * *' + pull_request: + push: + branches: + - "master" + schedule: + # runs once in a couple of days at 9am + - cron: '0 9 */2 * *' jobs: check-links: + if: '!cancelled()' # https://stackoverflow.com/a/58859404/2949645 runs-on: ubuntu-latest steps: - - uses: actions/checkout@master + - uses: actions/checkout@v3 - uses: gaurav-nelson/github-action-markdown-link-check@v1 with: - use-quiet-mode: 'yes' + use-quiet-mode: 'yes' # show only broken links use-verbose-mode: 'yes' - # for removing any false positives - config-file: .github/workflows/markdown-links-config.json + config-file: .github/workflows/markdown-links-config.json # for removing any false positives diff --git a/.github/workflows/markdown-links-config.json b/.github/workflows/markdown-links-config.json index ca43057bef..d54f377729 100644 --- a/.github/workflows/markdown-links-config.json +++ b/.github/workflows/markdown-links-config.json @@ -3,8 +3,23 @@ { "pattern": "^http://localhost" }, + { + "pattern": "^https://twitter.com/" + }, { "pattern": "^gaurav-nelson/" } + ], + "aliveStatusCodes": [403, 429, 200], + "httpHeaders": [ + { + "urls": [ + "https://docs.github.com/", + "https://opensource.org/" + ], + "headers": { + "Accept-Encoding": "zstd, br, gzip, deflate" + } + } ] } \ No newline at end of file diff --git a/test-plans/README.md b/test-plans/README.md index 1cc19ab86e..1d180aacd2 100644 --- a/test-plans/README.md +++ b/test-plans/README.md @@ -24,7 +24,7 @@ of these nodes with the other version's interop test. # Running all interop tests locally with Compose To run this test against all released libp2p versions you'll need to have the -(libp2p/test-plans)[https://github.com/libp2p/test-plans] checked out. Then do +[libp2p/test-plans](https://github.com/libp2p/test-plans) checked out. Then do the following (from the root directory of this repository): 1. Build the image: `docker build -t go-libp2p-head -f test-plans/PingDockerfile .`. From e26185fdace1482dedccc097e88307700ba914d4 Mon Sep 17 00:00:00 2001 From: Sahib Yar Date: Mon, 3 Jul 2023 05:56:29 +0500 Subject: [PATCH 4/8] Reverted some extra code based on PR comments --- .github/actions/go-test-setup/action.yml | 2 +- .github/workflows/link-check.yml | 2 -- .github/workflows/markdown-links-config.json | 8 +------- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/actions/go-test-setup/action.yml b/.github/actions/go-test-setup/action.yml index 6980722bb2..c7e4d11ac5 100644 --- a/.github/actions/go-test-setup/action.yml +++ b/.github/actions/go-test-setup/action.yml @@ -1,7 +1,7 @@ runs: using: "composite" steps: - - name: increase the UDP receive buffer size # see https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes + - name: increase the UDP receive buffer size # see https://github.com/lucas-clemente/quic-go/wiki/UDP-Receive-Buffer-Size shell: bash run: sysctl -w net.core.rmem_max=2500000 if: ${{ matrix.os == 'ubuntu' }} diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 009ad16df1..ad117a04b5 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -5,12 +5,10 @@ on: branches: - "master" schedule: - # runs once in a couple of days at 9am - cron: '0 9 */2 * *' jobs: check-links: - if: '!cancelled()' # https://stackoverflow.com/a/58859404/2949645 runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/markdown-links-config.json b/.github/workflows/markdown-links-config.json index d54f377729..95e3bb2ee5 100644 --- a/.github/workflows/markdown-links-config.json +++ b/.github/workflows/markdown-links-config.json @@ -5,18 +5,12 @@ }, { "pattern": "^https://twitter.com/" - }, - { - "pattern": "^gaurav-nelson/" } ], "aliveStatusCodes": [403, 429, 200], "httpHeaders": [ { - "urls": [ - "https://docs.github.com/", - "https://opensource.org/" - ], + "urls": ["https://docs.github.com/"], "headers": { "Accept-Encoding": "zstd, br, gzip, deflate" } From ba7e77beeb45bc7f4d829d81ab5b5e31447051a1 Mon Sep 17 00:00:00 2001 From: Sahib Yar Date: Thu, 6 Jul 2023 22:57:14 +0500 Subject: [PATCH 5/8] #2364 updated as per PR comments --- .github/workflows/markdown-links-config.json | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/markdown-links-config.json b/.github/workflows/markdown-links-config.json index 95e3bb2ee5..fdb9a4c3ae 100644 --- a/.github/workflows/markdown-links-config.json +++ b/.github/workflows/markdown-links-config.json @@ -5,14 +5,17 @@ }, { "pattern": "^https://twitter.com/" + }, + { + "pattern": " ^https://opensource.org/" } ], - "aliveStatusCodes": [403, 429, 200], + "aliveStatusCodes": [200], "httpHeaders": [ { "urls": ["https://docs.github.com/"], "headers": { - "Accept-Encoding": "zstd, br, gzip, deflate" + "Accept-Encoding": "*" } } ] From 179cd136cd8b69043d22acee168e7f33bfa3daad Mon Sep 17 00:00:00 2001 From: Sahib Yar Date: Thu, 6 Jul 2023 23:07:59 +0500 Subject: [PATCH 6/8] fixed type :| --- .github/workflows/markdown-links-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/markdown-links-config.json b/.github/workflows/markdown-links-config.json index fdb9a4c3ae..505831a198 100644 --- a/.github/workflows/markdown-links-config.json +++ b/.github/workflows/markdown-links-config.json @@ -7,7 +7,7 @@ "pattern": "^https://twitter.com/" }, { - "pattern": " ^https://opensource.org/" + "pattern": "^https://opensource.org/" } ], "aliveStatusCodes": [200], From 5ea669d8998c9181b083286bb15cba374b17f81b Mon Sep 17 00:00:00 2001 From: Marco Munizaga Date: Thu, 6 Jul 2023 11:32:22 -0700 Subject: [PATCH 7/8] Update .github/workflows/link-check.yml --- .github/workflows/link-check.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index ad117a04b5..87c895d44c 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -4,8 +4,6 @@ on: push: branches: - "master" - schedule: - - cron: '0 9 */2 * *' jobs: check-links: From 4d9d4ec190ee91a1a555805ca50d1b0cd918f0ab Mon Sep 17 00:00:00 2001 From: Sahib Yar Date: Fri, 7 Jul 2023 00:21:16 +0500 Subject: [PATCH 8/8] Removed dead links, to pass pipeline --- CHANGELOG.md | 4 ++-- examples/multipro/README.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2306f0ff89..b6ab14c177 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -195,8 +195,8 @@ Fix some test-utils used by https://github.com/libp2p/go-libp2p-kad-dht ### Metrics We've started instrumenting the entire stack. In this release, we're adding metrics for: -* the swarm: tracking incoming and outgoing connections, transports, security protocols and stream multiplexers in use: (https://github.com/libp2p/go-libp2p/blob/master/p2p/net/swarm/grafana-dashboards/swarm.json) -* the event bus: tracking how different events are propagated through the stack and to external consumers (https://github.com/libp2p/go-libp2p/blob/master/p2p/host/eventbus/grafana-dashboards/eventbus.json) +* the swarm: tracking incoming and outgoing connections, transports, security protocols and stream multiplexers in use: (https://github.com/libp2p/go-libp2p/blob/master/dashboards/swarm/swarm.json) +* the event bus: tracking how different events are propagated through the stack and to external consumers (https://github.com/libp2p/go-libp2p/blob/master/dashboards/eventbus/eventbus.json) Our metrics effort is still ongoing, see https://github.com/libp2p/go-libp2p/issues/1356 for progress. We'll add metrics and dashboards for more libp2p components in a future release. diff --git a/examples/multipro/README.md b/examples/multipro/README.md index db032848fb..6fb0b2e967 100644 --- a/examples/multipro/README.md +++ b/examples/multipro/README.md @@ -1,7 +1,7 @@ # Protocol Multiplexing using rpc-style protobufs with libp2p This example shows how to use protobufs to encode and transmit information between libp2p hosts using libp2p Streams. -This example expects that you are already familiar with the [echo example](https://github.com/libp2p/go-libp2p-examples/tree/master/echo). +This example expects that you are already familiar with the [echo example](https://github.com/libp2p/go-libp2p/tree/master/examples/echo). ## Build