fix: only announce TCP for now

libp2p · Jan 28, 2017 · 234ddbe · 234ddbe
1 parent 30517e6
commit 234ddbe
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 51 deletions.
diff --git a/examples/example.js b/examples/example.js
diff --git a/src/index.js b/src/index.js
@@ -39,11 +39,16 @@ class MulticastDNS extends EventEmitter {
       query.gotQuery(event, this.mdns, this.peerInfo, this.serviceTag, this.broadcast)
     })
 
-    callback()
+    setImmediate(() => callback())
   }
 
   stop (callback) {
-    this.mdns.destroy(callback)
+    if (!this.mdns) {
+      callback(new Error('MulticastDNS service had not started yet'))
+    } else {
+      this.mdns.destroy(callback)
+      this.mdns = undefined
+    }
   }
 }
 

diff --git a/src/query.js b/src/query.js
@@ -82,6 +82,10 @@ module.exports = {
   gotQuery: function (qry, mdns, peerInfo, serviceTag, broadcast) {
     if (!broadcast) { return }
 
+    const multiaddrs = tcp.filter(peerInfo.multiaddrs)
+    // Only announce TCP for now
+    if (multiaddrs.length === 0) { return }
+
     if (qry.questions[0] && qry.questions[0].name === serviceTag) {
       const answers = []
 
@@ -94,7 +98,6 @@ module.exports = {
       })
 
       // Only announce TCP multiaddrs for now
-      const multiaddrs = tcp.filter(peerInfo.multiaddrs)
       const port = multiaddrs[0].toString().split('/')[4]
 
       answers.push({

diff --git a/test/multicast-dns.spec.js b/test/multicast-dns.spec.js
@@ -83,7 +83,9 @@ describe('MulticastDNS', () => {
 
     parallel([
       (cb) => mdnsA.start(cb),
-      (cb) => mdnsC.start(cb)
+      (cb) => mdnsC.start(cb),
+      (cb) => mdnsD.start(cb)
+
     ], () => {
       mdnsA.once('peer', (peerInfo) => {
         expect(pC.id.toB58String()).to.eql(peerInfo.id.toB58String())