This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
[feature/multicast-dns] Added support for custom DNS server IP #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
suggested changes
Oct 4, 2022
rennokki
requested review from
achingbrain
and removed request for
wemeetagain and
mpetrunic
|
@rennokki thanks - can you please add a test to this PR |
|
@achingbrain Finally had some time to update the PR :) |
achingbrain
approved these changes
Oct 18, 2022
|
Thanks! |
|
@achingbrain Seems like the release broke: https://github.com/libp2p/js-libp2p-mdns/actions/runs/3275565715/jobs/5390636627 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
## [5.1.0](v5.0.0...v5.1.0) (2022-10-27) ### Features * add support for custom DNS server IP ([#142](#142)) ([3b6c7db](3b6c7db))
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for the prod, looks like GitHub was having a moment, all good now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to test my app for a custom DNS server (that's not the default one), and
multicastdns()does not supports it.I've added the
ipoption according to the multicast-dns dependency.