Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

bug: abort while reading on a connection #117

Open
vasco-santos opened this issue Apr 13, 2021 · 3 comments
Open

bug: abort while reading on a connection #117

vasco-santos opened this issue Apr 13, 2021 · 3 comments
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked

Comments

@vasco-santos
Copy link
Member

Since the async refactor we have been skipping this interface test as there is a bug here.
https://github.com/libp2p/js-libp2p-webrtc-direct/blob/v0.5.1/package.json#L65

@vasco-santos vasco-santos added kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked need/triage Needs initial labeling and prioritization labels Apr 13, 2021
@lidel lidel removed the need/triage Needs initial labeling and prioritization label Apr 26, 2021
@lidel lidel added P3 Low: Not priority right now help wanted Seeking public contribution on this issue labels Apr 26, 2021
@vogdb
Copy link
Contributor

vogdb commented Mar 2, 2022

Hi! I see that 'abort while reading' is not a part of tests anymore according to https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/libp2p-interface-compliance-tests/src/transport/dial-test.ts. Can you please clarify what repo should be used for interface compliance tests? I see there are:

Which one should be used here in this repo?

@vasco-santos
Copy link
Member Author

It looks like the one with @libp2p namespace per other transport modules: https://github.com/libp2p/js-libp2p-tcp/blob/master/package.json#L147

@achingbrain let us know if not

@vogdb
Copy link
Contributor

vogdb commented Mar 2, 2022

The one with @libp2p namespace exports only ESM modules, so this project needs to migrate to Typescript first, because currently CommonJS modules are used here.

@tinytb tinytb moved this to Backlog in js-libp2p Oct 11, 2022
@tinytb tinytb added this to js-libp2p Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked
Projects
Archived in project
Development

No branches or pull requests

3 participants