fix: race condition

libp2p · May 12, 2017 · 8dd9f3b · 8dd9f3b
1 parent 09220b9
commit 8dd9f3b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 15 deletions.
diff --git a/src/index.js b/src/index.js
@@ -133,14 +133,16 @@ class FloodSub extends EventEmitter {
     const subs = rpc.subscriptions
     const msgs = rpc.msgs
 
-    if (subs && subs.length) {
-      const peer = this.peers.get(idB58Str)
-      peer.updateSubscriptions(subs)
-    }
-
     if (msgs && msgs.length) {
       this._processRpcMessages(rpc.msgs)
     }
+
+    if (subs && subs.length) {
+      const peer = this.peers.get(idB58Str)
+      if (peer) {
+        peer.updateSubscriptions(subs)
+      }
+    }
   }
 
   _processRpcMessages (msgs) {
@@ -311,7 +313,7 @@ class FloodSub extends EventEmitter {
       if (peer.isWritable) {
         peer.sendSubscriptions(topics)
       } else {
-        setTimeout(checkIfReady.bind(peer), 100)
+        setImmediate(checkIfReady.bind(peer))
       }
     }
   }

diff --git a/test/2-nodes.js b/test/2-nodes.js
@@ -14,6 +14,7 @@ const utils = require('./utils')
 const first = utils.first
 const createNode = utils.createNode
 const expectSet = utils.expectSet
+const Buffer = require('safe-buffer').Buffer
 
 describe('basics between 2 nodes', () => {
   describe('fresh nodes', () => {
@@ -70,7 +71,7 @@ describe('basics between 2 nodes', () => {
           expect(fsA.peers.size).to.equal(1)
           expect(fsB.peers.size).to.equal(1)
           cb()
-        }, 250)
+        }, 1000)
       ], done)
     })
 
@@ -232,7 +233,7 @@ describe('basics between 2 nodes', () => {
           expectSet(first(fsA.peers).topics, ['Zb'])
 
           done()
-        }, 250)
+        }, 1000)
       })
     })
 
@@ -293,13 +294,11 @@ describe('basics between 2 nodes', () => {
           expect(fsA.peers.size).to.equal(1)
           expect(fsB.peers.size).to.equal(1)
 
-          fsA.stop(() => {
-            setTimeout(() => {
-              expect(fsB.peers.size).to.equal(0)
-              done()
-            }, 250)
-          })
-        }, 250)
+          fsA.stop(() => setTimeout(() => {
+            expect(fsB.peers.size).to.equal(0)
+            done()
+          }, 250))
+        }, 1000)
       })
     })
   })