Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: append peer id to dial addresses before filtering #2199

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix: append peer id to dial addresses before filtering #2199

merged 2 commits into from
Nov 6, 2023

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 4, 2023 •
edited
Loading

Some transports like WebRTC require the target peer id to be present on the multiaddr, so append the peer id before filtering by supported transport.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: append peer id to dial addresses before filtering
aef8b20 
Some transports like webrtc require the target peer id to be present
on the multiaddr, so append the peer id before filtering by
supported transport.
@achingbrain achingbrain requested a review from a team as a code owner November 4, 2023 12:36
@achingbrain achingbrain merged commit bafccd6 into master Nov 6, 2023
23 checks passed
@achingbrain achingbrain deleted the fix/prepend-peer-id-before-filtering branch November 6, 2023 08:22
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain