fix: dial relay when we are dialed via it but have no reservation #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an edge case where we receive an incoming connection attempt from a peer via a relay that we did not know we had a reservation on. This could happen if we restart or otherwise lose context. When this happens, attempt to listen on a p2p-circuit version of the incoming connection remote addr - this will cause us to refresh our reservation on the remote relay. Fixes recent interop test instability where the test configures a relay reservation on behalf of a node which then has no knowledge of it's reservations so tells identify peers that it has no listen addresses.
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Nov 27, 2023
…bp2p#2252) Fixes an edge case where we receive an incoming connection attempt from a peer via a relay that we did not know we had a reservation on. This could happen if we restart or otherwise lose context. When this happens, attempt to listen on a p2p-circuit version of the incoming connection remote addr - this will cause us to refresh our reservation on the remote relay. Fixes recent interop test instability where the test configures a relay reservation on behalf of a node which then has no knowledge of it's reservations so tells identify peers that it has no listen addresses.
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case where we receive an incoming connection attempt from a peer via a relay that we did not know we had a reservation on.
This could happen if we restart or otherwise lose context.
When this happens, attempt to listen on a p2p-circuit version of the incoming connection remote addr - this will cause us to refresh our reservation on the remote relay.
Fixes recent interop test "the dial request had no valid addresses" instability where the test configures a relay reservation on behalf of a node which then has no knowledge of it's reservations so tells identify peers that it has no listen addresses.
Change checklist