Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set libp2p status to started before stopping #2288

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: set libp2p status to started before stopping #2288

merged 1 commit into from
Dec 2, 2023

Conversation

achingbrain
Copy link
Member

In order to stop components that have been started during a failed startup, set the current status to started after catching the error - this.stop will immediately set it to stopping.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: set libp2p status to started before stopping
a3d568a 
In order to stop components that have been started during a failed
startup, set the current status to started after catching the
error - `this.stop` will immediately set it to `stopping`.
@achingbrain achingbrain requested a review from a team as a code owner December 2, 2023 09:26
@achingbrain achingbrain merged commit 09dd029 into main Dec 2, 2023
22 checks passed
@achingbrain achingbrain deleted the fix/set-status-before-stop branch December 2, 2023 09:42
@achingbrain achingbrain mentioned this pull request Dec 2, 2023
Merged
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain