notifyOnTransient also ignore disconnection events?

[marcus-pousette]

• Version:
  1.1.0 - 1.8.2

• Subsystem:
  registrar

Severity:

Medium/low

Description:

It seems like onDisconnect events are still emitted from transient connections shutting down even if notifyOnTransient is false.

I am receiving onDisconnect events when failing to establish a WebRTC connection

Steps to reproduce the error:

The seems to be intended behaviour (judging by the code).

js-libp2p/packages/libp2p/src/registrar.ts

Line 167 in f27138c

topology.onDisconnect?.(remotePeer)

Is it possible to fetch the closing connection here and skip if transient and notifyOnTransient is false ?

Feels more intuitive that connect and disconnect events are handled in the same way.

[marcus-pousette]

Going through some of the testing for transient connections this line

js-libp2p/packages/libp2p/test/registrar/registrar.spec.ts

Line 224 in fd4aea3

conn.transient = true

does not seem to have an effect of the outcome of the test.

If we would want to know whether a closing connection is transient or not the "peer:disconnect" info also needs to emit this

js-libp2p/packages/libp2p/src/connection-manager/index.ts

Line 474 in fd4aea3

this.events.safeDispatchEvent('peer:disconnect', { detail: connection.remotePeer })